doc: modernize Alpine build instructions#9204
Conversation
The Alpine compile guide still used the old `./configure && make` flow without Rust or uv. Update it to match the current build: install rustup (packaged rust/cargo can be older than the 1.85.0 MSRV), install uv for Python deps, and build with `RUST_PROFILE=release uv run make`. Changelog-None
enaples
added
the
QA
nGoline
left a comment
nGoline
left a comment
There was a problem hiding this comment.
Apart from the typo it looks great. As soon as you fix it I'll approve.
| postgresql-dev lowdown | ||
| ``` | ||
|
|
||
| Install Rust via rustup (required for Cargo: |
There was a problem hiding this comment.
| Install Rust via rustup (required for Cargo: | |
| Install Rust via rustup (required for Cargo): |
| To install for a specific version, for example, 24.05: | ||
| ```shell | ||
| docker pull elementsproject/lightningd:v24.05 |
There was a problem hiding this comment.
Would be nice to take this opportunity to update all the versions to 26.06.1
There was a problem hiding this comment.
Actually, it would be better to point everything to v26.09 (this will be merged at that point anyways)
|
|
||
| Checkout a release tag: | ||
| ```shell | ||
| git checkout v24.05 |
There was a problem hiding this comment.
Same here, update the version to 26.06.1
|
|
||
| Checkout a release tag: | ||
| ```shell | ||
| git checkout v24.05 |
There was a problem hiding this comment.
Same here, update the version to 26.06.1
|
|
||
| Checkout a release tag: | ||
| ```shell | ||
| git checkout v24.05 |
There was a problem hiding this comment.
Same here, update the version to 26.06.1
|
|
||
| Checkout a release tag: | ||
| ```shell | ||
| git checkout v25.02 |
There was a problem hiding this comment.
Same here, update the version to 26.06.1
| git checkout v26.06.1 | ||
| ``` | ||
|
|
||
| Clean up: |
There was a problem hiding this comment.
I've noticed you removed the clean-up steps. Isn't it desired for a minimal build like Alpine?
2 participants
Important
26.06 FREEZE April 30th: Non-bugfix PRs not ready by this date will wait for 26.09.
RC1 is scheduled on May 14th
The final release is scheduled for June 1st.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeWhat changes
The Alpine compile guide still used the old
./configure && makeflow without Rust oruv. Update it to match the current build: installrustup(packaged rust/cargo can be older than the 1.85.0 MSRV), installuvfor Python deps, and build withRUST_PROFILE=release uv run make.Changelog-None