ci: bind docker/pypi workflow inputs via env before shell - #9383
Open
SashaMIT wants to merge 2 commits into
Open
ci: bind docker/pypi workflow inputs via env before shell#9383SashaMIT wants to merge 2 commits into
SashaMIT wants to merge 2 commits into
Conversation
cdecker
approved these changes
Aug 6, 2026
Andezion
reviewed
Aug 6, 2026
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
The same vulnerable pattern - raw ${{ inputs.version }} / ${{ github.ref_name }} interpolated directly into run: - still exists, untouched, in the workflows that feed these three:
- check-release-tag.yml at line 34 -
echo "version=${{ inputs.version }}" >> "$GITHUB_OUTPUT", and line 44TAG_VERSION="${{ github.ref_name }}", and line 56tools/check-release.sh --version=${{ steps.resolve.outputs.version }} - release-build.yml at line 44-45 -
if [[ "${{ inputs.skip_validation }}" == "true" ]]and--force-version "${{ inputs.version }}" - release-publish.yml at line 54 -
VERSION="${{ inputs.version }}", the exact pattern this PR fixes elsewhere - pypi-build.yml at line 38 -
make update-pyln-versions NEW_VERSION=${{ inputs.version }}
Do you plan a follow-up pr for check-release-tag.yml/release-build.yml/release-publish.yml/pypi-build.yml, or was leaving them out intentional?
2 tasks
Author
Pass platforms-to-build, docker hub owner/version/push-latest, and dist-location through env: before run: scripts (script-injection class). Co-authored-by: Cursor <cursoragent@cursor.com> Changelog-None
Correct indentation and bind remaining version/ref inputs via env. Co-authored-by: Cursor <cursoragent@cursor.com>
cdecker
force-pushed
the
ci/bind-docker-workflow-inputs-env
branch
from
August 7, 2026 14:33
6d318d0 to
567cb8d
Compare
cdecker
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputs.platforms-to-buildthroughenv:before the docker-build matrix plan shell step.dh-repository-owner/version/push-latestthroughenv:before docker-publish tag construction.inputs.dist-locationthroughenv:before the pypi-publish shell step.run:scripts.Test plan
Changelog-None
Made with Cursor