askrene: clean up post-impression follow-ups - #9387
Conversation
| static const char *downgrade_askrene_layers(const tal_t *ctx, struct db *db, | ||
| bool convert_bias, | ||
| bool convert_impression) | ||
| bool convert_bias) |
There was a problem hiding this comment.
Nit.
By the AI logic the bool convert_impression was redundant.
It was there for us humans, to understand that if we add some new feature in 26.12
we can reuse downgrade_askrene_layers with convert_bias=false and convert_impression=false.
Therefore, it is not wrong but it is not necessary to remove it neither.
There was a problem hiding this comment.
I would leave tools/lightning-downgrade.c as it is.
|
@w3lld1: For CI to pass you need to include in this commit also the auto generated documentation files. Build the project add the generated files |
|
Thanks — addressed both points in Validation:
|
|
@w3lld1, since the second commit fixes the first, please squash them into a single commit. |
Remove dead state and parameters left after the askrene impression changes, and make the timestamp-ordered trimming logic stop at the first retained entry. Also harden plugin IDs and expired-offer invoice expiry handling, and correct the associated schema and utility documentation. Issue ElementsProject#9378 notes that the absolute-expiry subtraction can underflow when an offer is already expired. Clamp that case to a one-second relative expiry so zero retains its cancellation meaning. Changelog-None
83601c9 to
d5af48f
Compare
|
Thanks — squashed the branch into a single commit ( |
2 participants
Summary
Validation
-Werroruv run make check-source BASE_REF=origin/master BOLTDIR=../bolts CARGO=false CC=devtools/cc-nobuild SUPPRESS_GENERATION=1jqformatgit diff --check origin/master...HEADThe full linked build and integration suite are deferred to CI.
Checklist
Changelog-None; these are cleanups for unreleased v26.09 changes)-Werrorand source checks pass)Changelog-None
Fixes #9378