Fix simple close checks - #9417
Open
rustyrussell wants to merge 5 commits into
Open
Conversation
And fix prototypes which caused mocks to break. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/fix-simple-close-checks
branch
from
August 14, 2026 02:06
cf1ed1e to
a558e14
Compare
We're going to need it if lightningd wants to double-check the tx it gets from simpleclosed. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
From lightningd's perspective, there are two messages: 1. We got a signature on our closing tx. 2. We got a signature on their closing tx. The closer/closee naming is confusing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
simpleclosed checks it, but for thoroughness (and to prevent bugs and avoid any potential exploits in it) we need to check it too. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We want our own closing tx, but theirs might be too low-fee to use. Broadcast it, as a courtesy, but don't *rely* on it! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-EXPERIMENTAL: `experimental-simple-close` now doesn't save peer's closing transaction, so it can't be stuck with a too-low-fee tx.
rustyrussell
force-pushed
the
guilt/fix-simple-close-checks
branch
from
August 14, 2026 02:09
a558e14 to
8e22298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's still an experimental option, but two fixes:
The first was found by our internal LLM-assisted scanning. The second was found by me when fixing the first.