Repository navigation
Conversation
The test required the throttled peer to take more than three seconds for 17 messages. That bound came from the 500 bytes per second --dev-throttle-gossip allowed when the test was written. 5134ee4 raised the test rate to 1000 bytes per second and made the delay proportional with a one-second floor, so the 3,582 bytes now need two or three waits of a little over a second, and which it is depends on how the messages pack into the one-second windows. Two waits take 2.4 to 2.9 s and fail the bound. What the throttle guarantees is one wait of at least a second once a window is over budget, which these messages always are. Assert that, and check the throttle engaged through connectd's log line, which is written once per peer connection. Fixes: ElementsProject#9659 Changelog-None
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_gossip_throttle's three-second bound predates the August recalibration of the test throttle rate and delay (5134ee4): the 17 messages now take two or three waits depending on how they pack into the one-second windows, and two waits fail the bound. Assert the certain part, one wait of at least a second, and check the throttle's log line for each throttled connection.
Fixes #9659