Skip to content

Add EllesmereUI WonderBar addon#288

Draft
Kneeull wants to merge 3 commits intoEllesmereGaming:mainfrom
Kneeull:WonderBarRedux
Draft

Add EllesmereUI WonderBar addon#288
Kneeull wants to merge 3 commits intoEllesmereGaming:mainfrom
Kneeull:WonderBarRedux

Conversation

@Kneeull
Copy link
Copy Markdown
Contributor

@Kneeull Kneeull commented Apr 18, 2026

Introduce a new EllesmereUIWonderBar addon and register it with the main EllesmereUI. Adds EllesmereUIWonderBar/ (main Lua, options, .toc, TODO) and a large set of media assets (icons, profession/spec images, textures). Update EllesmereUI.lua to include the WonderBar in the ADDON_ROSTER and add it to the QoL addon group so it loads with the UI. The new module implements a modular, pivot-based bar (WB) with defaults, module registry, layout/slot logic, visibility/fade, popups, frame pooling, tooling for unlock/positioning and various helpers (formatting, tooltips, deferred actions).

--PR up for wonderbar - it's not done yet, currently getting a *todo list of it to add into the commit so you can review and make any changes if you feel like it -> It's nowhere near as complex options wise as the M+ timer but the general logic is a pain.

There are a couple of bugs I know of, one being the shop button that throws an error but it's unavoidable from all the implementations I've tried - including supprressing the error itself but it's a blizz error despite the shop opening?

Sorry it's not done, was intending to finish it today but honestly the day got away from me.

EllesmereUIWonderBar — Outstanding Issues

Remaining

High Priority

  • Duplicate horizontal/vertical layout code across all visual modules (Clock, System, Gold, Travel, SpecSwitch, Profession). Each OnRefresh contains a large if isSide then ... else ... block with near-identical sizing, text-fitting, and anchor logic (~40-50 lines each, ~300+ total). Worth extracting a shared layout helper, e.g. ApplyModuleLayout(frame, opts) taking icon+text+sub-text and a layout mode. Risk-prone — needs test passes for every module after.

  • Settings page in EUI not currently loading/being clickable Not sure where this has introduced. I suspect the new format of the EUI.lua isn't as simple as adding it in two places now.

Medium Priority

  • Module slots created upfront for all modules. ConstructBar makes a named slot frame for every registered module, even ones that are permanently disabled. Could be lazy: create slot in module OnCreate instead. Touches enable-flow timing — confirm Options panel doesn't reach for slots before module OnCreate runs.

Low

  • Travel macro seeding theoretical race — combat lockdown could (in theory) flip between InCombatLockdown() check and SetAttribute in PreClick. Window is sub-frame; not worth defending against.
  • GetWatchedFactionInfoCompat returns multiple values from a possibly-partial table — caller already guards if not name then return. No action needed, but will most likely refactor.

Notes for shop LUA error

  • I can't figure out how to fix this. Essentially when you click on the shop button, it loads but it giga errors for no reason? I can't figure out how to supress this either so if you can, you're a better man than I.

21x [ADDON_ACTION_FORBIDDEN] AddOn 'EllesmereUIWonderBar' tried to call the protected function 'UNKNOWN()'.
[!BugGrabber/BugGrabber.lua]:540: in function '?'
[!BugGrabber/BugGrabber.lua]:524: in function <!BugGrabber/BugGrabber.lua:524>
[C]: ?
[C]: in function 'EventStoreUISetShown'
[Blizzard_CatalogShop/Blizzard_CatalogShop_Inbound.lua]:15: in function 'SetShown'
[Blizzard_UIParent/Mainline/UIParent.lua]:957: in function 'ToggleStoreUI'
[EllesmereUIWonderBar/EllesmereUIWonderBar.lua]:3717: in function 'HandleGenericButtonClick'
[EllesmereUIWonderBar/EllesmereUIWonderBar.lua]:3904: in function <EllesmereUIWonderBar/EllesmereUIWonderBar.lua:3903>

Introduce a new EllesmereUIWonderBar addon and register it with the main EllesmereUI. Adds EllesmereUIWonderBar/ (main Lua, options, .toc, TODO) and a large set of media assets (icons, profession/spec images, textures). Update EllesmereUI.lua to include the WonderBar in the ADDON_ROSTER and add it to the QoL addon group so it loads with the UI. The new module implements a modular, pivot-based bar (WB) with defaults, module registry, layout/slot logic, visibility/fade, popups, frame pooling, tooling for unlock/positioning and various helpers (formatting, tooltips, deferred actions).
@Kneeull Kneeull marked this pull request as draft April 18, 2026 00:42
@Kneeull
Copy link
Copy Markdown
Contributor Author

Kneeull commented Apr 18, 2026

Update inline from old version that is fully rewritten (you know the story, I just missed the last line of crap that was added in my adventures 😂)

Update from working test version to correct EUI version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant