Skip to content

fix(assets): prefer bundled asset over CDN cache when resolving paths #2331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheNoumanDev wants to merge 1 commit into from
Closed

fix(assets): prefer bundled asset over CDN cache when resolving paths #2331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/ensemble/lib/util/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,12 +1137,18 @@ static BoxDecoration? getBoxDecoration(dynamic style) {
EnsembleConfigService.config["definitions"]?['local']?["path"];
return '${path}/assets/${stripQueryParamsFromAsset(asset)}';
} else if (provider == 'cdn') {
final assetName = stripQueryParamsFromAsset(asset);
// Prefer a bundled asset when present: renders instantly, no download.
if (LocalAssetsService.localAssets.contains(assetName)) {
return 'ensemble/assets/$assetName';
}
// Otherwise use the CDN cache (read via EnsembleAssetBundle).
final cachedCdnAsset =
CdnAssetCache.instance.getCachedFileIfValid(asset);
if (cachedCdnAsset != null) {
return cachedCdnAsset.path;
}
return 'ensemble/assets/${stripQueryParamsFromAsset(asset)}';
return 'ensemble/assets/$assetName';
} else {
return 'ensemble/assets/${stripQueryParamsFromAsset(asset)}';
}
Expand Down
Loading