Add useCardFeeds regression tests for empty linkedPolicyIDs#88359
Open
Add useCardFeeds regression tests for empty linkedPolicyIDs#88359
Conversation
Pin the corrected behavior of the include predicate in useCardFeeds: domain feeds whose `linkedPolicyIDs` is `[]` or `['']` (a legacy/invalid shape persisted by older clients and by DomainAPI's default when `preferredPolicy` was empty) should still match via `preferredPolicy` rather than being silently dropped. The predicate fix itself shipped in PR #88136; this commit adds the regression coverage that PR did not. Made-with: Cursor
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
PR #88136 (merged earlier today) fixed the
useCardFeedsinclude predicate so domain feeds whoselinkedPolicyIDsis[]or['']no longer get silently dropped, falling back topreferredPolicy/domainIDmatching as intended. That PR didn't add coverage inuseCardFeeds.test.ts, so this PR pins the corrected behavior with regression tests against the exact onyx shape that triggered the customer issue.linkedPolicyIDs: ['']with matchingpreferredPolicy-> feed is included.linkedPolicyIDs: []with matchingpreferredPolicy-> feed is included.linkedPolicyIDs: ['OTHER_POLICY'], currentpolicyIDnot in the list -> feed is excluded (regression guard for non-emptylinkedPolicyIDssemantics).linkedPolicyIDs: ['OTHER_POLICY', policyID]-> feed is included (multi-policy linkage).I verified locally that all 4 new tests fail when the predicate is reverted to the pre-#88136 short-circuit version, and pass against
main.No production code is changed.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/548636
PROPOSAL:
Tests
```ts
if (combinedCardFeed?.linkedPolicyIDs) {
return combinedCardFeed.linkedPolicyIDs.includes(policyID);
}
```
and confirm the two new `includes domain feeds when linkedPolicyIDs ...` tests fail.
Offline tests
N/A - tests-only change.
QA Steps
N/A - tests-only change, no production code modified.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari