Fix duplicate indicator on paid reports and error when bulk-duplicating non-reimbursable expenses by Krishna2323 · Pull Request #88442 · Expensify/App

Krishna2323 · 2026-04-21T14:59:00Z

Explanation of Change

Fixed Issues

$ #88257
$ #88300
PROPOSAL:

Tests

Test 1

Precondition:

Set Submissions to Instantly.
Disable Approvals and Payments.

Go to staging.new.expensify.com
Go to workspace chat.
Create two non-reimbursable expenses.
Retract each report (open report > More > Retract).
Go to Reports > Expenses.
Bulk select both expenses.
Click dropdown button > Duplicate expenses.
Go back to workspace chat.
Open both new reports.
Verify no error is show

Test 2

Open workspace chat
Create 2 distance manual expense
Open one expense and split the expense
Select both split expense and hold them
Select them again and duplicate the expenses
Note in duplicate expense preview hold violation is not shown
Open one of duplicate expense and note no hold message is shown

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-04-22.00-53-40.mp4

Monosnap.screencast.2026-04-22.01-09-01.mp4

…ng non-reimbursable expenses Signed-off-by: krishna2323 <belivethatkg@gmail.com>

… behavioral impact Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-04-21T15:21:20Z

@codex review

chatgpt-codex-connector · 2026-04-21T15:35:52Z

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

codecov · 2026-04-21T15:51:04Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/TransactionUtils/index.ts	`83.37% <ø> (ø)`
src/libs/actions/IOU/Duplicate.ts	`94.07% <60.00%> (-1.37%)`	⬇️
... and 124 files with indirect coverage changes

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-04-21T19:40:06Z

@codex review

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector · 2026-04-21T19:54:09Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-04-21T20:12:31Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…separate PR Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ae3e2b873

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-04-21T23:58:20Z

@codex review

chatgpt-codex-connector · 2026-04-22T00:09:25Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MelvinBot · 2026-04-22T02:40:10Z

Code Review

The changes look correct. A few notes:

Split logic in bulkDuplicateExpenses is sound. The optimistic IOU report gets statusNum: CLOSED baked in by buildOptimisticExpenseReport → getExpenseReportStateAndStatus for instant-submit + submit-and-close + non-reimbursable policies. canAddTransaction checks statusNum directly on the passed object (not from Onyx), so there's no stale-state risk within the synchronous loop. The comment at line 1032 ("once a split happens every subsequent expense will also split") is accurate for this path.

hold: undefined is correct. Clearing the hold reference prevents duplicated transactions from inheriting the original's hold state, consistent with how originalTransactionID and source are already cleared.

shouldDeferAutoSubmit logic is correct. After a split, deferring is unnecessary since the policy immediately closes each report anyway.

One minor nit: The blank line added in TransactionUtils/index.ts is a no-op whitespace change — consider dropping it to keep the diff focused.

No blocking issues found.

situchan · 2026-04-22T07:08:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

situchan · 2026-04-22T13:40:39Z

#88257 is sill reproducible

Screen.Recording.2026-04-22.at.7.39.38.PM.mov

situchan · 2026-04-22T13:42:45Z

Create two **non-**reimbursable expenses.

Don't forget this when try to reproduce. Issue is not reproducible for reimbursable expenses.

situchan · 2026-04-22T13:52:29Z

RequestMoney api:

payload:

response:

@JS00001 can you please check in backend why this request failed?

JS00001 · 2026-04-22T13:55:40Z

message: '403 New expense cannot be added to this report
User is trying to add expense to a non-draft Non-Reimbursable report with Instant Submit Enabled and No Approvers

This happens if:
The policy is instant submit with no approver AND the report has only non reimbursable transactions AND the report is not a draft

situchan · 2026-04-22T13:56:53Z

ok @Krishna2323 I think the new duplicated expense is still being added to the existing report instead of new one.

…actly Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2026-04-22T14:18:16Z

@codex review

Krishna2323 · 2026-04-22T14:18:23Z

@situchan issue fixed

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5f89d22c7d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-22T14:26:24Z

+<<<<<<< krishna2323/issue/84281-followups-2
+import {isInstantSubmitEnabled, isSubmitAndClose} from '@libs/PolicyUtils';
+=======
 import {isPolicyAccessible} from '@libs/PolicyUtils';
+>>>>>>> main


Remove unresolved merge-conflict markers

The import block still contains raw conflict markers (<<<<<<<, =======, >>>>>>>), which makes this file invalid TypeScript and will fail parsing in lint/build/test pipelines immediately. This is a release-blocking regression because any environment that compiles src/libs/actions/IOU/Duplicate.ts cannot run.

Useful? React with 👍 / 👎.

situchan · 2026-04-22T14:55:18Z

 import {getExistingTransactionID} from '@libs/IOUUtils';
 import * as NumberUtils from '@libs/NumberUtils';
 import Parser from '@libs/Parser';
+<<<<<<< krishna2323/issue/84281-followups-2


Please fix bad merge

Made-with: Cursor

Fix duplicate indicator on paid reports and error when bulk-duplicati…

d43b7b8

…ng non-reimbursable expenses Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot Bot assigned Krishna2323 Apr 21, 2026

Revert MoneyRequestHeader isDuplicate parameter change to avoid wider…

d89644d

… behavioral impact Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Fix bulk duplicate test flakiness caused by random policy settings

7740d6c

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 2 commits April 22, 2026 01:00

Fix auto-submit not triggering for split reports during bulk duplication

bf8e38b

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Fix bulk-duplicated expense stuck in Draft under instant-submit policies

bdb72d3

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Fix duplicated expenses inheriting hold status from original transaction

040f71e

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review April 21, 2026 20:12

Krishna2323 requested review from a team as code owners April 21, 2026 20:12

melvin-bot Bot requested review from heyjennahay and situchan and removed request for a team and heyjennahay April 21, 2026 20:12

melvin-bot Bot removed the request for review from a team April 21, 2026 20:12

Revert isSettled check in isDuplicate, will fix Expensify#88305 in a …

0ae3e2b

…separate PR Signed-off-by: krishna2323 <belivethatkg@gmail.com>

This was referenced Apr 21, 2026

Expense - Error shows up when duplicating non-reimbursable expenses #88257

Open

Expense-Hold violation is not shown in preview for duplicate split expenses. #88300

Open

remove space.

f58c144

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread src/libs/actions/IOU/Duplicate.ts Outdated

Remove overly broad policyAlwaysSplits check in bulk duplication

8ac3346

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

JS00001 previously approved these changes Apr 22, 2026

View reviewed changes

Narrow policyWillSplitReport to match canAddTransaction conditions ex…

8f7b877

…actly Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 dismissed JS00001’s stale review via 8f7b877 April 22, 2026 14:13

chatgpt-codex-connector Bot reviewed Apr 22, 2026

View reviewed changes

situchan reviewed Apr 22, 2026

View reviewed changes

Merge branch 'main' into krishna2323/issue/84281-followups-2

b865982

Made-with: Cursor

Krishna2323 force-pushed the krishna2323/issue/84281-followups-2 branch from 5f89d22 to b865982 Compare April 22, 2026 15:11

Conversation

Krishna2323 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Test 1

Test 2

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

codecov Bot commented Apr 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Krishna2323 commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 21, 2026

Uh oh!

melvin-bot Bot commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Apr 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 22, 2026

Uh oh!

MelvinBot commented Apr 22, 2026

Uh oh!

situchan commented Apr 22, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Apr 22, 2026

Uh oh!

situchan commented Apr 22, 2026

Uh oh!

situchan commented Apr 22, 2026

Uh oh!

JS00001 commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Apr 22, 2026

Uh oh!

Krishna2323 commented Apr 22, 2026

Uh oh!

Krishna2323 commented Apr 22, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Apr 21, 2026 •

edited

Loading

codecov Bot commented Apr 21, 2026 •

edited by github-actions Bot

Loading

JS00001 commented Apr 22, 2026 •

edited

Loading