[No QA] Docs updates for E/A#96603 correct member vs admin room open flow#96713
[No QA] Docs updates for E/A#96603 correct member vs admin room open flow#96713MelvinBot wants to merge 3 commits into
Conversation
Co-authored-by: Jakub Nowakowski <sumo-slonik@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
I'm on it |
|
LGTM 🚀 |
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted correction to Find-Rooms-in-a-Workspace.md to reflect the behavior change from #96603 (the Workspace Rooms page released to all members and admins). The edits correct the room-open flow so it distinguishes between Workspace admins (open the room details page, then Go to room) and Workspace members (open the conversation directly). The change is accurate, well-scoped, and improves correctness. All feedback below applies only to the modified lines. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
A preview of your ExpensifyHelp changes have been deployed to https://0f91f8e0.helpdot.pages.dev ⚡️ Updated articles: |
Explanation of Change
#96603 removed the
workspaceRoomsPagebeta and released the Workspace Rooms page (the Rooms directory) to all workspace members and admins.The existing help article
Find Rooms in a Workspacealready covers the feature and contained no beta-gating language, so it did not need to be un-gated. However, it described the row-click behavior inaccurately for members.Per
WorkspaceRoomsPage.tsx, selecting a room behaves differently by role:The article previously said everyone opens a details page and then clicks Go to room. This PR corrects the navigation steps and the "What happens after you open a room" section to distinguish the admin and member flows.
Files changed
docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md@sumo-slonik, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.