Skip to content

[No QA] Docs updates for E/A#96603 correct member vs admin room open flow#96713

Open
MelvinBot wants to merge 3 commits into
mainfrom
claude-workspace-rooms-docs-96603
Open

[No QA] Docs updates for E/A#96603 correct member vs admin room open flow#96713
MelvinBot wants to merge 3 commits into
mainfrom
claude-workspace-rooms-docs-96603

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

#96603 removed the workspaceRoomsPage beta and released the Workspace Rooms page (the Rooms directory) to all workspace members and admins.

The existing help article Find Rooms in a Workspace already covers the feature and contained no beta-gating language, so it did not need to be un-gated. However, it described the row-click behavior inaccurately for members.

Per WorkspaceRoomsPage.tsx, selecting a room behaves differently by role:

  • Workspace admins → open the room details page (which has a Go to room action).
  • Workspace members → open the room conversation directly (no details page, no Go to room step).

The article previously said everyone opens a details page and then clicks Go to room. This PR corrects the navigation steps and the "What happens after you open a room" section to distinguish the admin and member flows.

Files changed

  • docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md

@sumo-slonik, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Jakub Nowakowski <sumo-slonik@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 22, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#96603 correct member vs admin room open flow [No QA] Docs updates for E/A#96603 correct member vs admin room open flow Jul 22, 2026
@OSBotify

This comment has been minimized.

@sumo-slonik

Copy link
Copy Markdown
Contributor

I'm on it

@sumo-slonik

Copy link
Copy Markdown
Contributor

LGTM 🚀

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 25, 2026 03:20
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 25, 2026 03:20
@OSBotify

This comment has been minimized.

Comment thread docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md
Comment thread docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, targeted correction to Find-Rooms-in-a-Workspace.md to reflect the behavior change from #96603 (the Workspace Rooms page released to all members and admins). The edits correct the room-open flow so it distinguishes between Workspace admins (open the room details page, then Go to room) and Workspace members (open the conversation directly). The change is accurate, well-scoped, and improves correctness. All feedback below applies only to the modified lines.

Scores Summary

  • Readability: 9/10 - The rewritten "What happens after you open a room" section is clear and scannable, using a role-based bullet list. One trailing-whitespace nit on the "displays the rooms you can access" line.
  • AI Readiness: 9/10 - Task-based headings, full feature names (Rooms directory, Workspace admins/members), and complete YAML metadata including internalScope are all present and unchanged. The edits keep the single-workflow focus intact.
  • Style Compliance: 9/10 - UI labels (Rooms, Go to room, Workspaces), sentence casing, and the unified navigation phrasing "(on the left on web, on the bottom on mobile)" all follow HELPSITE_NAMING_CONVENTIONS.md. Terminology (Workspace member/admin) is correct.

Key Findings

  • Accurate correction: the previous text implied every user opens a details page then clicks Go to room; the new version correctly splits admin vs. member flows, matching WorkspaceRoomsPage.tsx.
  • Good consistency fix: adding the missing period to step 1 aligns it with the other numbered steps.
  • Minor nit: a trailing space was introduced at the end of the line "The Rooms directory displays the rooms you can access in that workspace. " - remove it.
  • Note (not blocking): HELP_AUTHORING_GUIDELINES.md Section 6 says to avoid combining Admin + Member flows "unless inseparable." Here they are genuinely inseparable (same action, divergent outcome), so the role-based bullet treatment is appropriate.

Recommendations

  • Remove the trailing whitespace on the "displays the rooms you can access in that workspace." line.
  • Optional: consider whether the shortened step 3 ("Select a room from the list.") should briefly point readers to the "What happens after you open a room" section, since the outcome now varies by role. Not required.

Files Reviewed

  • docs/articles/new-expensify/chat/Find-Rooms-in-a-Workspace.md - Approved with one minor whitespace nit. Correction is accurate and compliant with governance.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott requested a review from a team July 25, 2026 04:25
@melvin-bot

melvin-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot
melvin-bot Bot requested a review from CortneyOfstad July 25, 2026 04:25
@melvin-bot

melvin-bot Bot commented Jul 25, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 25, 2026 04:25
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://0f91f8e0.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants