[No QA] Update certificate pins for NewDot - #96722
Conversation
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b8e663406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "XPujjYNyJh3N+7AgvBfcVXaEl1IhDB1OdoL6t+4bhbQ=", | ||
| "kIdp6NNEd8wsugYyyIYFsi1ylMCED3hZbSR8ZFsa/A4=", |
There was a problem hiding this comment.
Sync HybridApp pin sources before merging
Changing the canonical pin set here without also moving the Mobile-Expensify gitlink (it is unchanged in this commit) leaves the HybridApp mobile build on the previous TrustKit/OkHttp pin lists; the certificate-pinning README documents those Mobile-Expensify files as the sources used by production/TestFlight HybridApp traffic. In that context, the July 7 CA migration will still produce monitor-mode pinning failures/noisy Sentry events for mobile users, and it would block traffic if enforcement is flipped later, even though the App-side pins are current. Please update or link the corresponding Mobile-Expensify pin rotation with this change.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The Mobile-Expensify PR is up: https://github.com/Expensify/Mobile-Expensify/pull/14024
|
Do I need to review this PR? @staszekscp |
|
No product review needed. |
|
Conflict resolved! |
Explanation of Change
Updates certificate pins for
expensify.comFixed Issues
$ https://github.com/Expensify/Expensify/issues/633469
PROPOSAL:
Tests
Offline tests
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari