[Copy Workspace Settings] Fix hidden currency in copy settings#96730
Conversation
Only force currency into selected copy parts when workflows need it for bank-account compatibility.
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-22.at.6.10.09.PM.mov |
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.4.43-0 🚀
|
No help site changes requiredI reviewed the changes in this PR against the help site articles under Why: This is a bug fix, not a behavior or feature change from the user's perspective. It corrects an edge case in the Copy settings / Duplicate workspace flow where the Currency setting was incorrectly forced onto the confirmation page even though it was hidden on the Copy settings page (when the selected workspaces already share the same currency). The fix simply makes the confirmation page match what was already intended and shown. Docs impact: The only article covering this feature is If you'd prefer the article's settings list be expanded to reflect the full set of options shown in the current UI (including conditionally-shown ones like Currency), that would be a separate documentation task independent of this fix — let me know and I can scope it. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.43-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This fixes a copy policy settings deploy blocker where Currency appeared on the confirmation page even though it was hidden on the Copy settings page.
The select features page now only forces
currencyinto the selected copy parts when workflows actually need currency for bank-account compatibility. This keeps hidden same-currency settings out of the confirm page while preserving the existing workflow compatibility guard.Fixed Issues
$ #96715
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A