Skip to content

Send reveal_card_details reason from the missing-personal-details magic code page#96733

Draft
MelvinBot wants to merge 2 commits into
mainfrom
claude-revealCardMagicCodeReason
Draft

Send reveal_card_details reason from the missing-personal-details magic code page#96733
MelvinBot wants to merge 2 commits into
mainfrom
claude-revealCardMagicCodeReason

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

When an account is missing personal details, pressing Reveal on a virtual Expensify Card routes into the MissingPersonalDetails flow, which ends on MissingPersonalDetailsMagicCodePage. That page requested the magic code with no reason (requestValidateCodeAction()), so the backend fell back to the generic "Log in to your account or access a secure feature." email instead of the card-specific "…Reveal details for your Expensify card ending in NNNN" copy.

The sibling direct-reveal page (ExpensifyCardVerifyAccountPage) already passes reasonCode: reveal_card_details + reasonCardID; this path was simply never migrated. This PR makes MissingPersonalDetailsMagicCodePage supply the same reason only when it is revealing a virtual card (isVirtualCard), mirroring the sibling page. The physical-card shipping variant that shares this page keeps the reason-less call, since its magic code authorizes shipping, not a reveal.

Because the callback also backs the "Didn't receive a magic code?" resend, the resent email is corrected too. The change is type-safe: the ResendValidateCodeParams union already forces reasonCardID to accompany REVEAL_CARD_DETAILS.

Note: the "Add personal info" form shown at step 4 is working as designed — revealing a virtual card requires legal name/DOB/address, so a brand-new account must complete them first. The defect addressed here is the email copy.

Fixed Issues

$ #96604
PROPOSAL: #96604 (comment)

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your change worked.

Automated coverage added in this PR: unit tests in tests/actions/UserTest.ts assert that requestValidateCodeAction forwards {reasonCode: reveal_card_details, reasonCardID} to RESEND_VALIDATE_CODE when revealing, and null when called without params.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

MelvinBot and others added 2 commits July 22, 2026 11:52
Co-authored-by: Olly <Ollyws@users.noreply.github.com>
Co-authored-by: Olly <Ollyws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants