83869 migrate transaction duplicate v6#96738
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0569e8cef5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if (comparisonResult.change.merchant) { | ||
| return ROUTES.TRANSACTION_DUPLICATE_REVIEW_MERCHANT_PAGE.getRoute(threadReportID, backTo); | ||
| return createDynamicRoute(DYNAMIC_ROUTES.TRANSACTION_DUPLICATE_REVIEW_MERCHANT.path, backTo); |
There was a problem hiding this comment.
Build duplicate field routes from the review page
When getReviewNavigationRoute is called from the transaction-detail KEEP_THIS_ONE action, backTo is the current transaction route (for example search/view/...), not the duplicate review route. Using it as the createDynamicRoute base builds URLs like search/view/.../merchant, but these new duplicate dynamic routes only accept the duplicate review/dynamic duplicate screens as entry screens, so the navigation cannot resolve to the review-fields page. Build the base from ROUTES.TRANSACTION_DUPLICATE_REVIEW_PAGE.getRoute(threadReportID, backTo) and append the dynamic suffix to that instead.
Useful? React with 👍 / 👎.
|
No product review needed. |
Explanation of Change
Fixed Issues
$ #83868
$ #83869
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Preconditions:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-22.at.20.11.11.mov