Remove NewtonSolver from hyperelasticity demo#3929
Remove NewtonSolver from hyperelasticity demo#3929chrisrichardson wants to merge 17 commits intomainfrom
Conversation
|
On a related note, where are we with providing the things needed to interface with SNES from C++? |
|
Is the long term plan to remove the DOLFINx C++ Newton solver, in favor of another solver (like SNES)? If we plan to remove it, I think we need to give some deprecation notice to the C++ users + an alternative that is not copying solver logic across multiple user files. |
|
Yes, the plan is to remove NewtonSolver and provide some tooling/examples to help people interface SNES from C++. However, I've never done it myself, so I have no idea where to even begin. |
|
I think that the example here is sufficiently simple that reproducing the logic of NewtonSolver (and simplifying) is OK (only adds 70 lines of code). |
|
Could you add that deprecated message so we can get this merged for 0.10? |
Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>
|
@jhale @michalhabera @schnellerhase - any further comments, or shall I merge? |
No description provided.