Repository navigation
Documentdb - #9
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Missing bind-mount directories and a missing configurator completion dependency can break startup, while masked secret-read failures allow startup with an empty password.
3 open issues
What changed in this PR
Adds DocumentDB as an alternative configuration database for the FastNetMon Advanced Docker Compose deployment.
Changes:
- Adds DocumentDB services, secret-based startup, collation configuration, and FastNetMon connection settings.
- Adds persistent storage for DocumentDB and FastNetMon library/cache data.
- Documents the new option and adds minimal and full-stack DocumentDB CI configurations.
| File | Description |
|---|---|
volumes.yml |
Defines DocumentDB data and FastNetMon library/cache volumes. |
services/fastnetmon/custom-entry.sh |
Adds DocumentDB-specific authentication settings. |
services/documentdb/custom-entry.sh |
Loads the database password before starting DocumentDB. |
scripts/init_storage_default_dirs.sh |
Creates new storage directories using a shared loop. |
README.md |
Documents the DocumentDB image version and Compose option. |
docker-compose.yml |
Mounts FastNetMon library and cache storage. |
docker-compose.documentdb.yml |
Defines DocumentDB, collation setup, and FastNetMon integration. |
.gitignore |
Ignores generated library storage contents. |
.github/workflows/ci.yml |
Adds DocumentDB CI coverage while retaining minimal MongoDB coverage. |
.env.template |
Sets the default DocumentDB image version. |
Review effort: Balanced
Comment on lines
+26
to
+27
| - fastnetmon_lib:/var/lib/fastnetmon/ | ||
| - fastnetmon_cache:/var/cache/fastnetmon/ |
| #!/bin/sh | ||
| set -e | ||
|
|
||
| export PASSWORD="$(cat /run/secrets/mongo_password)" |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Mandatory bind mounts break fresh-checkout startup because required directories are not provisioned, while unreadable or empty DocumentDB secrets can allow startup with a public default password.
3 open issues
1 resolved since last review
Review effort: Balanced
| #!/bin/sh | ||
| set -e | ||
|
|
||
| export PASSWORD="$(cat /run/secrets/mongo_password)" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentDB support