Add Ruby 4.0 cross-compilation support#104
Merged
stackmystack merged 1 commit intoFaveod:masterfrom Apr 30, 2026
Merged
Conversation
ehostalery-sweep
commented
Apr 7, 2026
| _(m).must_be_kind_of Hash | ||
| _(m.keys.sort).must_equal %w[product product.left product.right sum sum.left] | ||
| _(m.values.all? { |n| n.instance_of?(TreeSitter::Node) }).must_be_equal true | ||
| _(m.values.all?(TreeSitter::Node)).must_be_equal true |
Contributor
Author
There was a problem hiding this comment.
This fixes the Rubocop warning: https://github.com/Faveod/ruby-tree-sitter/actions/runs/24083197660/job/70260411473
Collaborator
|
I should have mentioned this in my first comment, apologies, but could could you please re-write the commit messages to follow the norms of this repo? |
ehostalery-sweep
force-pushed
the
support-ruby-4.0
branch
from
873bdbc to
853dc69
Compare
Contributor
Author
|
@stackmystack Is it better? Not sure how to re-write it to be honest, I tried to have a look at the commits on master |
Contributor
Author
|
Hello @stackmystack , sorry to ping you, did you have time to have a look? |
Collaborator
I'm sorry I got very busy lately, I will try to do it tonight, if not, it will definitely land during the week-end. |
Collaborator
|
I just release 2.1.1. Enjoy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precompiled platform gems (e.g.
x86_64-linux-gnu) currently setrequired_ruby_versionto>= 3.1, < 3.5.dev,making them incompatible with Ruby 4.0. This is because:
rake-compiler-dock ~> 1.5doesn't include Ruby 4.0 cross-compilation toolchainsruby_cc_version('~> 3.1')excludes Ruby 4.0 (~>means< 4.0)Changes
rake-compiler-dockto~> 1.11(v1.11.0 added Ruby 4.0.0 support)'~> 4.0'toruby_cc_versionso Ruby 4.0 is included in cross-compilation targetsFixes #103