fix: ensure stdin state is correct for searchable multi-select prompt by yongnianliu · Pull Request #620 · Fission-AI/OpenSpec

yongnianliu · 2026-01-30T03:45:16Z

Summary by CodeRabbit

Bug Fixes
- Fixed arrow key navigation in searchable multi-select component that was unresponsive after the welcome screen. Keyboard input now responds correctly without requiring Enter to be pressed first.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-30T03:45:33Z

📝 Walkthrough

Walkthrough

The changes fix a stdin state bug affecting arrow key input in searchableMultiSelect after the welcome screen. The welcome-screen no longer manages stdin state post-entry, while searchable-multi-select now explicitly prepares stdin (raw mode and resume) before initialization.

Changes

Cohort / File(s)	Summary
Stdin State Management `src/ui/welcome-screen.ts`, `src/prompts/searchable-multi-select.ts`	Redistributes stdin state responsibility: welcome-screen removes post-Enter stdin restoration/pause, delegating to next prompt; searchable-multi-select adds pre-initialization stdin setup (raw mode and resume) to fix arrow key failures.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Arrows dance where once they froze,
Raw mode blooms in careful prose,
Welcome screen steps back with grace,
Let the prompt take its rightful place! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing stdin state handling for the searchable multi-select prompt by adjusting how stdin is managed between the welcome screen and subsequent prompts.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vibe-kanban-cloud · 2026-01-30T03:46:58Z

Review Complete

Your review story is ready!

View Story

Comment !reviewfast on this PR to re-generate the story.

greptile-apps · 2026-01-30T03:48:10Z

Greptile Overview

Greptile Summary

Fixed stdin state management issue where arrow keys didn't work in searchableMultiSelect prompt after the welcome screen.

Root cause: waitForEnter() in welcome-screen.ts was restoring raw mode and pausing stdin, leaving it in an incorrect state for the next prompt.

Changes:

welcome-screen.ts: Removed stdin cleanup (setRawMode restore and pause()) in waitForEnter() to leave stdin active
searchable-multi-select.ts: Added explicit stdin state initialization before creating the prompt to ensure raw mode is enabled and stdin is resumed

The fix follows a defensive programming approach where searchableMultiSelect now takes responsibility for ensuring stdin is in the correct state, rather than relying on previous functions to clean up properly.

Confidence Score: 4/5

This PR is safe to merge with minimal risk
The fix directly addresses the reported issue with a clear, well-documented solution. The defensive approach of ensuring stdin state in searchableMultiSelect is solid. Minor deduction for the unused wasRaw variable and lack of test coverage verification
No files require special attention - changes are straightforward stdin state management fixes

Important Files Changed

Filename	Overview
src/prompts/searchable-multi-select.ts	Added stdin state initialization to ensure raw mode and resume state before prompt creation
src/ui/welcome-screen.ts	Removed stdin cleanup (setRawMode restore and pause) to allow next prompt to handle stdin state

Sequence Diagram

sequenceDiagram
    participant User
    participant InitCommand
    participant WelcomeScreen
    participant stdin as process.stdin
    participant SearchableMultiSelect

    Note over User,SearchableMultiSelect: Before Fix: stdin left in paused state

    User->>InitCommand: Run init command
    InitCommand->>WelcomeScreen: showWelcomeScreen()
    WelcomeScreen->>stdin: setRawMode(true)
    WelcomeScreen->>stdin: resume()
    User->>WelcomeScreen: Press Enter
    Note over WelcomeScreen,stdin: OLD: setRawMode(wasRaw) + pause()
    WelcomeScreen-->>InitCommand: Return
    InitCommand->>SearchableMultiSelect: searchableMultiSelect()
    Note over SearchableMultiSelect,stdin: Arrow keys don't work (stdin paused)
    User->>SearchableMultiSelect: Press Enter first
    Note over SearchableMultiSelect: Inquirer resumes stdin
    User->>SearchableMultiSelect: Arrow keys now work

    Note over User,SearchableMultiSelect: After Fix: stdin state properly managed

    User->>InitCommand: Run init command
    InitCommand->>WelcomeScreen: showWelcomeScreen()
    WelcomeScreen->>stdin: setRawMode(true)
    WelcomeScreen->>stdin: resume()
    User->>WelcomeScreen: Press Enter
    Note over WelcomeScreen: NEW: Don't restore/pause stdin
    WelcomeScreen-->>InitCommand: Return
    InitCommand->>SearchableMultiSelect: searchableMultiSelect()
    SearchableMultiSelect->>stdin: Check isTTY
    SearchableMultiSelect->>stdin: setRawMode(true) if not raw
    SearchableMultiSelect->>stdin: resume()
    Note over SearchableMultiSelect: stdin now in correct state
    User->>SearchableMultiSelect: Arrow keys work immediately

greptile-apps

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-01-30T03:48:18Z

Additional Comments (1)

src/ui/welcome-screen.ts
Variable wasRaw captured but never used after removing the cleanup code

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/ui/welcome-screen.ts
Line: 90:90

Comment:
Variable `wasRaw` captured but never used after removing the cleanup code

How can I resolve this? If you propose a fix, please make it concise.

TabishB

Nice find on the root cause. One suggestion below.

TabishB · 2026-01-30T04:43:52Z

src/ui/welcome-screen.ts

        stdin.removeListener('data', onData);
-        stdin.setRawMode(wasRaw);
-        stdin.pause();
+        // Don't restore raw mode or pause stdin here - let the next prompt handle stdin state


The searchableMultiSelect() guard already fixes this. I'd revert this change so waitForEnter() keeps cleaning up after itself. No need for both.

TabishB · 2026-02-02T06:54:20Z

@yongnianliu Let me know if you can take a look at the above comment

fix: ensure stdin state is correct for searchable multi-select prompt

86344e5

yongnianliu requested a review from TabishB as a code owner January 30, 2026 03:45

greptile-apps bot reviewed Jan 30, 2026

View reviewed changes

Merge branch 'main' into main

be8f132

TabishB requested changes Jan 30, 2026

View reviewed changes

TabishB added 4 commits January 30, 2026 17:11

Merge branch 'main' into main

5a4936b

Merge branch 'main' into main

eff669f

Merge branch 'main' into main

52327fe

Merge branch 'main' into main

cfcf06e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure stdin state is correct for searchable multi-select prompt#620

fix: ensure stdin state is correct for searchable multi-select prompt#620
yongnianliu wants to merge 6 commits intoFission-AI:mainfrom
yongnianliu:main

yongnianliu commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

vibe-kanban-cloud bot commented Jan 30, 2026

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

TabishB left a comment

Uh oh!

TabishB Jan 30, 2026 •

edited

Loading

Uh oh!

yongnianliu Feb 3, 2026

Uh oh!

TabishB commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yongnianliu commented Jan 30, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

vibe-kanban-cloud bot commented Jan 30, 2026

Review Complete

Uh oh!

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Jan 30, 2026

Uh oh!

TabishB left a comment

Choose a reason for hiding this comment

Uh oh!

TabishB Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yongnianliu Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

TabishB commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yongnianliu commented Jan 30, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

TabishB Jan 30, 2026 •

edited

Loading