test(Billing): Post-deploy E2E does not include plans#7337
Conversation
Vercel's flagsmith-frontend-staging project bundles with ENV=dev and already ships the full plan catalogue, while the staging E2E bundle (e.g. the post-API-deploy run in .reusable-deploy-ecs.yml) is built with ENV=staging and was missing the plans field — trial buttons were gated on chargebeePlanId so they silently didn't render. Copy the plan IDs from project_dev.js into project_staging.js so both staging bundles are configured identically. project_prod.js already has its own plans block (prod Chargebee tenant uses different plan IDs) and doesn't need changes. beep boop
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, reopen this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
the
front-end
Docker builds report
|
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
|
Visual Regression16 screenshots compared. See report for details. |
2 participants
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Follow-up to #7335. The post-API-deploy E2E run (triggered by
.reusable-deploy-ecs.ymlwithenvironment: staging) failed on the new@saasbilling test becausefrontend/env/project_staging.jswas missing theplansfield —PaymentButtonis gated onchargebeePlanIdbeing truthy, so the trial buttons never rendered.The Vercel-deployed
staging.flagsmith.comwasn't affected because theflagsmith-frontend-stagingVercel project bundles withENV=dev, so it inherits the plan IDs fromproject_dev.js. The asymmetry was silent until the@saastest started exercising that path.Copy the same plan IDs into
project_staging.jsso staging-ENV bundles render the trial buttons.project_prod.jsalready carries its ownplansblock (differentstartup.annualID because the prod Chargebee tenant has a different catalogue) — no changes needed there.How did you test this code?
ENV=stagingbundle) will now render the trial buttons rather than hiding them.@saasbilling test locally againststaging.flagsmith.comon main and against the PR preview for fix(Billing): Free trial buttons stop working after toggling yearly/monthly #7335 — both passed pre-merge because those builds useENV=dev. This change brings the staging-ENV bundle to parity.