Repository navigation
fix(nvidia): kept the monitor's identity in a short pulse's relight - #595
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An output relit on a DisplayPort short pulse, the brief hotplug pulse by which a monitor asks for its DisplayPort registers to be read, named no monitor in gfxfb's GET_OUTPUT, as the relight left out the monitor's identity, the maker, name, product code and serial number its EDID gives.
Changes
relight_at_lit_timingcopies the head'slit_monitorinto the one-timingoutput_modesit builds from what the head kept, as every other light takes the identity from its EDID read. GET_OUTPUT then names the same monitor before and after the relight, so stlxdm, which finds its stored layouts by these identities, sees no new monitor.lit_monitor's comment namesset_upand the driver task as its only writers, so the driver task, on which the relight runs, may read it without the output lock.a_short_pulse_relights_an_output_whose_link_is_lost_at_the_timing_it_hadalso checks that the relit output is reported lit with its EDID's maker and name, AOC and AG241QG4.