Fix ipc_shm_arena_lend build-break bug when no (empty) jemalloc API prefix specified. / Comment and/or doc changes. / ipc_shm_arena_lend CMake-build knob JEMALLOC_PREFIX renamed FLOW_IPC_JEMALLOC_PREFIX to avoid collision with same-named variable elsewhere. / ipc_shm_arena_lend CMake-build knobs JEMALLOC_LIB and JEMALLOC_INCLUDE_PATH renamed JEMALLOC_LIBRARIES and JEMALLOC_INCLUDEDIR, respectively, because these names are already used by the default auto-searcher. / ipc_shm_arena_lend CMake-build script internally improved when searching for jemalloc install.
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…JEMALLOC_PREFIX to avoid collision with same-named variable elsewhere.
…ALLOC_PREFIX renamed FLOW_IPC_JEMALLOC_PREFIX to avoid collision with same-named variable elsewhere. / ipc_shm_arena_lend CMake-build knobs JEMALLOC_LIB and JEMALLOC_INCLUDE_PATH renamed JEMALLOC_LIBRARIES and JEMALLOC_INCLUDEDIR, because these names are already used by the default auto-searcher. / ipc_shm_arena_lend CMake-build script internally improved when searching for jemalloc install. (Impl: Use the new recommendation in Flow FlowLikeLib.cmake doc-comment: if no find_package() then: try pkg_check_modules(), unless user provided overrides -- then use those.)>
…pe deficiency supplies at least 1 use-case for still wanting the find_library()/find_path() fallback in the i_s_a_l build script.)>
…ipc_session: (opportunistic) Comment and/or doc changes.> <ipc_shm_arena_lend: ipc_shm_arena_lend CMake-build knob `JEMALLOC_PREFIX` renamed `FLOW_IPC_JEMALLOC_PREFIX` to avoid collision with same-named variable elsewhere. / ipc_shm_arena_lend CMake-build knobs `JEMALLOC_LIB` and `JEMALLOC_INCLUDE_PATH` renamed `JEMALLOC_LIBRARIES` and `JEMALLOC_INCLUDEDIR`, respectively, because these names are already used by the default auto-searcher. / ipc_shm_arena_lend CMake-build script internally improved when searching for jemalloc install.>
ygoldfeld
changed the title
JEMALLOC_PREFIX renamed FLOW_IPC_JEMALLOC_PREFIX to avoid collision with same-named variable elsewhere. / ipc_shm_arena_lend CMake-build knobs JEMALLOC_LIB and JEMALLOC_INCLUDE_PATH renamed JEMALLOC_LIBRARIES and JEMALLOC_INCLUDEDIR, respectively, because these names are already used by the default auto-searcher. / ipc_shm_arena_lend CMake-build script internally improved when searching for jemalloc install.JEMALLOC_PREFIX renamed FLOW_IPC_JEMALLOC_PREFIX to avoid collision with same-named variable elsewhere. / ipc_shm_arena_lend CMake-build knobs JEMALLOC_LIB and JEMALLOC_INCLUDE_PATH renamed JEMALLOC_LIBRARIES and JEMALLOC_INCLUDEDIR, respectively, because these names are already used by the default auto-searcher. / ipc_shm_arena_lend CMake-build script internally improved when searching for jemalloc install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Flow-IPC/ipc_shm_arena_lend#59
API notes (ATTN when writing release notes):
JEMALLOC_PREFIXtoFLOW_IPC_JEMALLOC_PREFIXJEMALLOC_LIBtoJEMALLOC_LIBRARIESJEMALLOC_INCLUDE_PATHtoJEMALLOC_INCLUDEDIRTo code reviewer:
Submodule reviews have been handled. In
ipcit is a comment change only. Forgoing code review.