Skip to content

Eslint v9 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hardillb merged 5 commits into from
Dec 30, 2025
Merged

Eslint v9 #548

hardillb merged 5 commits into from
Dec 30, 2025

Conversation

@hardillb
Copy link
Contributor

@hardillb hardillb commented Dec 30, 2025

closes #547

Description

convert to eslint v9

Related Issue(s)

#547

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb
Add comments about private CA certs to services
4ea905d 
part of #525

Adds commented out Env Var pointing at /opt/flowfuse-device/chain.pem
to make enableding private CA certs support easier.
@hardillb
Pass lint
227ae46
@hardillb
Convert to eslint v9
a091b77 
closes #547
@hardillb
revert private ca changes
7042b54
@hardillb hardillb self-assigned this Dec 30, 2025
@ppawlowski
Copy link
Contributor

ppawlowski commented Dec 30, 2025

A release dry-run against this branch didn't fail, so I'm fine with changes made to the .releaserc.js file.

Steve-Mcl
Steve-Mcl reviewed Dec 30, 2025
View reviewed changes
@hardillb hardillb requested a review from Steve-Mcl December 30, 2025 13:41
Steve-Mcl
Steve-Mcl approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppawlowski we only run eslint on node 18. wondering if there is any milage to shifting that to node 20. Additionally, is it not time we added node 22 (and maybe even node24?) to the test matrix? (Both are LTS)?

@ppawlowski
Copy link
Contributor

ppawlowski commented Dec 30, 2025

LGTM

@ppawlowski we only run eslint on node 18. wondering if there is any milage to shifting that to node 20. Additionally, is it not time we added node 22 (and maybe even node24?) to the test matrix? (Both are LTS)?

Both are possible and easy to implement. Please create a separate issue and specify the versions we want to lint against.

@Steve-Mcl Steve-Mcl mentioned this pull request Dec 30, 2025
Closed
@Steve-Mcl
Copy link
Contributor

Steve-Mcl commented Dec 30, 2025

@hardillb are you awaiting Piotras approval - or should I merge?

@hardillb hardillb merged commit d4df4d7 into main Dec 30, 2025
11 checks passed
@hardillb hardillb deleted the eslint-v9 branch December 30, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

@ppawlowski ppawlowski Awaiting requested review from ppawlowski

Assignees

@hardillb hardillb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update eslint to v9

4 participants

@hardillb @ppawlowski @Steve-Mcl