Check for updates once daily#771
Merged
Merged
Conversation
Collaborator
Author
Collaborator
Author
Comment on lines
+73
to
+75
| if shouldCatchUp { | ||
| updater.checkForUpdatesInBackground() | ||
| } |
Contributor
There was a problem hiding this comment.
When automatic update checks are disabled, this catch-up path can still call checkForUpdatesInBackground() after the stored last-check date is missing or older than 24 hours. That makes launch contact the update feed even though the user disabled automatic checks. Gate the catch-up call on automaticallyChecksForUpdates so manual checks still work while automatic launch checks stay off.
Suggested change
| if shouldCatchUp { | |
| updater.checkForUpdatesInBackground() | |
| } | |
| if updater.automaticallyChecksForUpdates && shouldCatchUp { | |
| updater.checkForUpdatesInBackground() | |
| } |
FuJacob
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #768
Root cause
Sparkle persists its update interval in user defaults, which take precedence over the value in
CotabbyInfo.plist. Existing installations could therefore retain a shorter interval. Cotabby also calledcheckForUpdatesInBackground()on every launch, bypassing Sparkle's normal last-check scheduling.User impact
Automatic update checks now occur at most once per day. Sparkle continues to use its persisted last-check date, while users can still request an immediate check manually.
Validation
git diff --checkplutil -lint CotabbyInfo.plistxcodebuild -project Cotabby.xcodeproj -scheme Cotabby -destination 'platform=macOS' build -derivedDataPath build/DerivedData CODE_SIGNING_ALLOWED=NO -quietSUScheduledCheckInterval = 86400Greptile Summary
This PR changes Sparkle update checks to follow a daily cadence. The main changes are:
Confidence Score: 4/5
This is close, but one launch-check behavior should be fixed before merging.
Cotabby/Services/Utilities/AppUpdateManager.swift
Important Files Changed
Reviews (3): Last reviewed commit: "fix: catch up overdue update checks at l..." | Re-trigger Greptile