Conversation
arng40
requested review from
MelReyCG,
corbett5,
rrsettgast and
wrtobin
as code owners
arng40
added
flag: ready for review
flag: no rebaseline
MelReyCG
approved these changes
Mar 27, 2026
| double clamp( double v, double min, double max ) | ||
| { | ||
| return std::min( max, std::max( min, v )); | ||
| return LvArray::math::min( max, LvArray::math::max( min, v )); |
Contributor
There was a problem hiding this comment.
Thanks for this change, could be added to the automatic code rules and the docs. There's some more in log-parts.
| size_t const borderSpaceWidth = m_nbBorderChar * 2 + m_borderMargin * 2; | ||
|
|
||
| size_t const formattingCharSize = borderSpaceWidth; | ||
| size_t const decorationWidth = borderSpaceWidth; |
Contributor
There was a problem hiding this comment.
Names are better in your PR, indeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a length bug where when we have a description
>100 charactersthe logPart maxLength is not taken into account