Add lake tile type#181
Draft
biljanaorescanin wants to merge 15 commits into
Draft
Conversation
biljanaorescanin
added
enhancement
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
biljanaorescanin
changed the title
This was referenced Jul 8, 2026
biljanaorescanin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of 3 PRs that help us run just lake tiles in GEOSldas offline mode.
Functionality testing:
Tested for run
tile_type 100 20(zero diff to current global and globalcs tests).Tested for
tile_type 100 19 20we can only doglobalcsfor now. Test was done for c360.Plumbing now works and the remaining risk is stability and science sanity, working on longer run for validation.
Preliminary RST magnitude and spatial comparisons for offline vs coupled 2day run are at same locations with very similar range.
GEOS-ESM/GEOSgcm_GridComp#1470
GEOS-ESM/GEOSldas#862