Skip to content

Please consider the following formatting changes to #15786 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #15786 #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/DPLDigitizerParam.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ struct DPLDigitizerParam : public o2::conf::ConfigurableParamHelper<DPLDigitizer
float timeResolution = 0.020f; ///< time resolution sigma in ns (20 ps default)
float tdcBin = 0.010f; ///< TDC time bin (10 ps default)
float efficiency = 0.98f; ///< detection efficiency
std::string efficiencyFilePath{}; ///< optional efficiency map file path.
std::string efficiencyFilePath{}; ///< optional efficiency map file path.
///< The efficiency map is currently available at /alice/cern.ch/user/g/glucia/ALICE3/IOTOF/pixelEfficiency/PixelEfficiencyMap_TH2.root. FIXME to be removed once switch to CCDBFetcher
int chargeThreshold = 100; ///< charge threshold in Nelectrons
int minChargeToAccount = 7; ///< minimum charge contribution to account
Expand Down
2 changes: 1 addition & 1 deletion Detectors/Upgrades/ALICE3/IOTOF/simulation/include/IOTOFSimulation/Digitizer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class Digitizer : public TObject
static constexpr float cm2um = 1e4f; ///< centimeters to micrometers conversion

const o2::iotof::GeometryTGeo* mGeometry = nullptr; ///< IOTOF geometry
TH2D* mEfficiencyMap = nullptr; ///< Efficiency map for the detector
TH2D* mEfficiencyMap = nullptr; ///< Efficiency map for the detector

std::vector<o2::iotof::Chip> mChips; //! Chips in the detector, indexed by chip ID
std::deque<std::unique_ptr<std::vector<o2::iotof::McLabelRef>>> mExtraLabelBuffer; //! buffer for multiple mc labels to the same pixel
Expand Down
6 changes: 3 additions & 3 deletions Detectors/Upgrades/ALICE3/IOTOF/simulation/src/Digitizer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,15 @@ void Digitizer::process(const std::vector<o2::itsmft::Hit>* hits, int evID, int
void Digitizer::processHit(const o2::itsmft::Hit& hit, int evID, int srcID)
{
// Process a single hit and create a digit if it passes all cuts

// Get detector element ID
const int chipID = hit.GetDetectorID();
auto& chip = mChips[chipID];
if (chip.isDisabled()) {
LOG(debug) << "Hit rejected because chip " << chipID << " is disabled";
return;
}

// middle position of the hit in the sensor frame
const auto& matrix = mGeometry->getMatrixL2G(chipID);
auto xyzPositionStart = matrix ^ hit.GetPosStart();
Expand Down Expand Up @@ -331,7 +331,7 @@ bool Digitizer::isEfficient(const float x, const float z) const
// Apply efficiency cut using random number
const auto& digitizerParams = o2::iotof::DPLDigitizerParam::Instance();
if (mEfficiencyMap) {
//int bin = mEfficiencyMap->FindBin(x * o2::iotof::Digitizer::cm2um, z * o2::iotof::Digitizer::cm2um);
// int bin = mEfficiencyMap->FindBin(x * o2::iotof::Digitizer::cm2um, z * o2::iotof::Digitizer::cm2um);
int bin = mEfficiencyMap->FindBin(x * o2::iotof::Digitizer::cm2um, z * o2::iotof::Digitizer::cm2um);
float efficiency = mEfficiencyMap->GetBinContent(bin);
LOG(debug) << "Efficiency map check: x=" << x * o2::iotof::Digitizer::cm2um << ", z=" << z * o2::iotof::Digitizer::cm2um << ", bin=" << bin << ", efficiency=" << efficiency;
Expand Down
Loading