Log tool-call environment variable names instead of values

[anticomputer]

Problem

Debug logging in mcp_client_params printed the full tool-call environment dict, including values resolved from {{ env('...') }}. That environment routinely carries credentials such as GH_TOKEN, so at DEBUG level the secret values were written to the logs.

Reported at

seclab-taskflow-agent/src/seclab_taskflow_agent/mcp_utils.py

Lines 220 to 221 in 8de19ce

	logging.debug("Tool call environment: %s", env)
	if args:

Fix

Log only the environment variable names, never the values. A small _env_names helper returns the sorted keys, applied at all three env log sites (stdio pre-swap, stdio post-swap, and streamable). The names are kept so debug output still shows which variables are configured.

This is log-only: the environment passed through to the MCP server is unchanged.

Scope

Env values only, as discussed. Command args logging is left as-is.

Validation

• New test test_mcp_client_params_logs_env_names_not_secret_values asserts a resolved secret value never appears in the logs, the variable names still do, and the real env is still handed to the server. Verified it fails without the fix.
• Full unit suite (544 passed) and CI-parity lint pass.

[Copilot]

Pull request overview

This PR hardens MCP toolbox debug logging by ensuring tool-call environment variables are logged safely (names only), preventing accidental secret leakage when environment values are resolved from {{ env('...') }} templates.

Changes:

• Add _env_names() helper to log only environment variable keys (never values) in mcp_client_params.
• Update debug log statements for stdio and streamable toolbox initialization/environment logging to use _env_names().
• Add a regression test asserting secret values do not appear in debug logs while env names still do and resolved env is still passed through.

Show a summary per file

File	Description
src/seclab_taskflow_agent/mcp_utils.py	Replace env-value debug logging with env-name logging via _env_names() to avoid leaking credentials.
tests/test_mcp_utils.py	Add test coverage to ensure secrets are not emitted in debug logs while functionality remains unchanged.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Low

[Copilot]

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Low