fix: text encoding issues#91
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses text encoding issues when reading/searching files inside local GitHub zip archives by decoding zip entry bytes as UTF-8 (with replacement on decode errors), and adds regression tests to ensure non-ASCII content is handled correctly without leaking Python bytes representations.
Changes:
- Decode zip entry lines via
line.decode("utf-8", errors="replace")insearch_zipfile()to correctly match non-ASCII search terms. - Decode zip entry lines in
get_file()so returned content isstr(notbytes) and safe for downstream formatting/joining. - Add tests covering non-ASCII text, invalid UTF-8 bytes, and tool outputs to ensure decoded/numbered lines are returned.
Show a summary per file
| File | Description |
|---|---|
| tests/test_local_file_viewer.py | Adds regression tests verifying decoded output for non-ASCII and invalid UTF-8 content. |
| src/seclab_taskflows/mcp_servers/local_file_viewer.py | Fixes zipfile line handling by decoding bytes to str for search and file reads. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
anticomputer
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.