Skip to content

chore(vertexai): Decommission token_count region tags#4362

Open
angelcaamal wants to merge 1 commit into
mainfrom
remove-vextexai-token-count
Open

chore(vertexai): Decommission token_count region tags#4362
angelcaamal wants to merge 1 commit into
mainfrom
remove-vextexai-token-count

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR decommissions the token_count region tags from Vertex AI samples.

Fixes Internal: b/527550101

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the region tags 'generativeaionvertexai_gemini_token_count' and 'generativeaionvertexai_gemini_token_count_advanced' from the countTokens.js and countTokensAdvanced.js files. There are no review comments, so I have no feedback to provide.

@amcolin amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kef131 Kef131 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angelcaamal angelcaamal marked this pull request as ready for review June 24, 2026 21:30
@angelcaamal angelcaamal requested review from a team as code owners June 24, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants