Skip to content

chore(vertexai/grounding): Decommission grounding region tags#4363

Merged
iennae merged 1 commit into
mainfrom
chore/vertexai-decommission-grounding-region-tags
Jun 25, 2026
Merged

chore(vertexai/grounding): Decommission grounding region tags#4363
iennae merged 1 commit into
mainfrom
chore/vertexai-decommission-grounding-region-tags

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Description

This PR decommissions the grounding region tags from Vertex AI samples.

Fixes Internal: b/527561405

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Jun 24, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the START and END region tags from the groundingPrivateDataBasic.js and groundingPublicDataBasic.js files. There are no review comments, and I have no feedback to provide.

@Kef131 Kef131 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angelcaamal angelcaamal marked this pull request as ready for review June 24, 2026 21:35
@angelcaamal angelcaamal requested review from a team as code owners June 24, 2026 21:35
@iennae iennae merged commit 99de4de into main Jun 25, 2026
20 checks passed
@iennae iennae deleted the chore/vertexai-decommission-grounding-region-tags branch June 25, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants