Skip to content

chore(vertexai): Decommission inference region tags#4365

Open
angelcaamal wants to merge 1 commit into
mainfrom
chore/vertexai-decommission-inference-region-tag
Open

chore(vertexai): Decommission inference region tags#4365
angelcaamal wants to merge 1 commit into
mainfrom
chore/vertexai-decommission-inference-region-tag

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

This PR decommissions the inference region tags from Vertex AI samples.

Fixes Internal: b/528029726

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: genai labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the snippet region tags ([START ...] and [END ...]) from several JavaScript files in the generative-ai/snippets/inference/ directory, including nonStreamMultiModalityBasic.js, nonStreamTextBasic.js, streamMultiModalityBasic.js, and streamTextBasic.js. There are no review comments to address, and I have no additional feedback to provide.

@angelcaamal angelcaamal marked this pull request as ready for review June 25, 2026 22:10
@angelcaamal angelcaamal requested review from a team as code owners June 25, 2026 22:10
@snippet-bot

snippet-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: genai samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant