Skip to content

Make the node graph's "Merge Selected Nodes" target the right-clicked node, and fix it crashing#4252

Merged
Keavon merged 1 commit into
masterfrom
merge-selected-nodes
Jun 18, 2026
Merged

Make the node graph's "Merge Selected Nodes" target the right-clicked node, and fix it crashing#4252
Keavon merged 1 commit into
masterfrom
merge-selected-nodes

Conversation

@Keavon

@Keavon Keavon commented Jun 18, 2026

Copy link
Copy Markdown
Member

Fixes #4250.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several improvements and bug fixes to the node graph and document management systems. It adds a test to ensure merging un-exported nodes during inspection does not crash, updates right-click behavior to auto-select unselected nodes for context actions, and prevents dangling monitor node inputs by verifying subnetwork exports before monitoring. Additionally, it refactors the document name generation logic. Feedback is provided regarding a potential naming collision bug in the document name generation logic, where the binary search on a transformed array with duplicates can behave unpredictably; a simpler linear scan is suggested instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread editor/src/messages/portfolio/portfolio_message_handler.rs Outdated
@Keavon Keavon force-pushed the merge-selected-nodes branch from da568e1 to 8090e61 Compare June 18, 2026 05:21
@Keavon Keavon merged commit 5b00893 into master Jun 18, 2026
9 checks passed
@Keavon Keavon deleted the merge-selected-nodes branch June 18, 2026 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash using merge nodes when data panel open

1 participant