Allow databank to be actually disabled#2860
Open
WALHAY wants to merge 4 commits intoGregTechCEu:masterfrom
Open
Allow databank to be actually disabled#2860WALHAY wants to merge 4 commits intoGregTechCEu:masterfrom
WALHAY wants to merge 4 commits intoGregTechCEu:masterfrom
Conversation
ALongStringOfNumbers
added
type: refactor
Zorbatron
reviewed
Sep 4, 2025
src/main/java/gregtech/common/metatileentities/multi/electric/MetaTileEntityDataBank.java
Outdated
Show resolved
Hide resolved
Zorbatron
reviewed
Oct 13, 2025
Member
Zorbatron
left a comment
Zorbatron
left a comment
There was a problem hiding this comment.
Everything looks good in a test world, but when I turn the data bank on in the gui, the "Idling" line takes a frame or two longer to turn to "Providing Data" than the energy usage line being added which looks a little weird. This is probably due to the checks in updateFormedValid taking an extra tick to run.
Also if the data bank doesn't have power, the "Idling" line is gray when it's enabled, but gold/yellow when it's disabled. This might not be exclusive to the data bank, I haven't checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Even if Data Bank was disabled it still continued to consume energy and provide recipes.
Implementation Details
Added isWorkingEnabled check in Data Bank energy consumption loop. Changed configureDisplayText to hide energy consumption line when Data Bank is disabled.
Outcome
Data Bank now will stop consuming energy and providing recipes when disabled.
Potential Compatibility Issues
No compatibility issues