Skip to content

优化主题包管理页面列表项#6270

Merged
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:awaw
Jun 29, 2026
Merged

优化主题包管理页面列表项#6270
Glavo merged 1 commit into
HMCL-dev:mainfrom
CiiLu:awaw

Conversation

@CiiLu

@CiiLu CiiLu commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Glavo

Glavo commented Jun 29, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c736f4a496

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

HBox.setHgrow(content, Priority.ALWAYS);
center.setCursor(Cursor.HAND);
FXUtils.onClicked(center, () -> {
FXUtils.onClicked(ripplerContainer, () -> {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Prevent action buttons from triggering row selection

For non-built-in packs, the reveal/delete buttons are children of the root wrapped by this RipplerContainer. FXUtils.onClicked installs a bubbling MOUSE_CLICKED handler, while button actions fire from the button itself, so a primary click on either action button can also reach this handler and call selectThemePack, opening the apply/details dialog after reveal/delete. Keep the row-click handler limited to the non-button area or filter/consume clicks originating from the action buttons.

Useful? React with 👍 / 👎.

@Glavo Glavo merged commit c0f699b into HMCL-dev:main Jun 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants