Skip to content

Fix: Prevent theme pack tags from disappearing #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KSSJW wants to merge 3 commits into from
Closed

Fix: Prevent theme pack tags from disappearing #6272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f05fb0f
Fix: prevent theme pack tags from disappearing
KSSJW Jun 29, 2026
6ec3639
Refactor: Unnecessary import
KSSJW Jun 29, 2026
ea9fadf
Refactor: Improve scrolling performance
KSSJW Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions HMCL/src/main/java/org/jackhuang/hmcl/ui/main/ThemePackManagementPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,28 +673,36 @@ private ThemePackItemCell(ThemePackManagementPage page) {
/// Updates this cell for one installed theme pack.
@Override
protected void updateItem(ThemePackManager.@Nullable InstalledThemePack themePack, boolean empty) {
super.updateItem(themePack, empty);
ThemePackManager.@Nullable InstalledThemePack oldThemePack = getItem();

content.getTags().clear();
iconImage.setImage(null);
iconFallback.setVisible(false);
super.updateItem(themePack, empty);

if (empty || themePack == null) {
setGraphic(null);
return;
}

ThemePackManifest manifest = themePack.manifest();
@Nullable String description = manifest.displayDescription();

if (oldThemePack != themePack) {
content.getTags().clear();

if (themePack.builtin()) {
content.addTag(i18n("theme_pack.builtin"));
}
content.addTag(i18n("theme_pack.version", manifest.version()));
content.addTag(i18n("theme_pack.themes", manifest.themes().size()));

iconImage.setImage(null);
iconFallback.setVisible(false);
page.updateIcon(iconImage, iconFallback, themePack, manifest.icon());
}

setGraphic(graphic);

ThemePackManifest manifest = themePack.manifest();
page.updateIcon(iconImage, iconFallback, themePack, manifest.icon());
content.setTitle(manifest.displayName());
@Nullable String description = manifest.displayDescription();
content.setSubtitle(StringUtils.isBlank(description) ? manifest.id() : description);
Comment thread
KSSJW marked this conversation as resolved.
if (themePack.builtin()) {
content.addTag(i18n("theme_pack.builtin"));
}
content.addTag(i18n("theme_pack.version", manifest.version()));
content.addTag(i18n("theme_pack.themes", manifest.themes().size()));

if (themePack.builtin()) {
right.getChildren().clear();
Expand Down