Skip to content

Improve integration test harperLifecycle: rename setupHarper, add docs for killHarper/logDir/env vars#235

Merged
Ethan-Arrowood merged 5 commits intomainfrom
integration-test-docs-and-types
Mar 18, 2026
Merged

Improve integration test harperLifecycle: rename setupHarper, add docs for killHarper/logDir/env vars#235
Ethan-Arrowood merged 5 commits intomainfrom
integration-test-docs-and-types

Conversation

@Ethan-Arrowood
Copy link
Member

@Ethan-Arrowood Ethan-Arrowood commented Mar 16, 2026

Summary

  • Renames setupHarperstartHarper throughout (clearer name; makes the restart pattern killHarper / startHarper read naturally)
  • Collapses the old startHarper passthrough into the single startHarper implementation
  • Documents previously undocumented exports: killHarper, HarperContext, logDir, and env vars HARPER_INTEGRATION_TEST_LOG_DIR, HARPER_INTEGRATION_TEST_INSTALL_PARENT_DIR, HARPER_INTEGRATION_TEST_INSTALL_SCRIPT
  • Fixes stale .mts file extension references in README (actual files are .ts)
  • Corrects SetupHarperOptionsStartHarperOptions and marks config/env as required to match the interface
  • Adds process and logDir fields to the ContextWithHarper interface definition in the docs

Test plan

  • Verify existing integration tests still import and run correctly with the renamed startHarper
  • Check that crash-replay.test.ts restart pattern (killHarperstartHarper) works end-to-end

🤖 Generated with Claude Code

@Ethan-Arrowood Ethan-Arrowood requested a review from a team as a code owner March 16, 2026 21:27
Copy link
Member

@DavidCockerill DavidCockerill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

These naming changes will also need to be updated in harper-pro

Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kriszyp kriszyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but like David said, would be nice to have a corresponding harper-pro PR since this will break the tests there, I believe. Should be an easy rename though.

@Ethan-Arrowood
Copy link
Member Author

Okay before I merge I will work on harper-pro PR too.

Copy link
Member

@heskew heskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice update 👍

@Ethan-Arrowood
Copy link
Member Author

Okay I created the harper-pro PR. I'm going to squash and merge this now and then get things updated on the harper-pro side

@Ethan-Arrowood Ethan-Arrowood merged commit d563619 into main Mar 18, 2026
21 of 22 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the integration-test-docs-and-types branch March 18, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants