Improve integration test harperLifecycle: rename setupHarper, add docs for killHarper/logDir/env vars#235
Merged
Ethan-Arrowood merged 5 commits intomainfrom Mar 18, 2026
Conversation
DavidCockerill
approved these changes
Mar 17, 2026
Member
DavidCockerill
left a comment
There was a problem hiding this comment.
Nice!
These naming changes will also need to be updated in harper-pro
kriszyp
approved these changes
Mar 17, 2026
Member
kriszyp
left a comment
There was a problem hiding this comment.
This looks good, but like David said, would be nice to have a corresponding harper-pro PR since this will break the tests there, I believe. Should be an easy rename though.
Member
Author
|
Okay before I merge I will work on |
Member
Author
|
Okay I created the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setupHarper→startHarperthroughout (clearer name; makes the restart patternkillHarper/startHarperread naturally)startHarperpassthrough into the singlestartHarperimplementationkillHarper,HarperContext,logDir, and env varsHARPER_INTEGRATION_TEST_LOG_DIR,HARPER_INTEGRATION_TEST_INSTALL_PARENT_DIR,HARPER_INTEGRATION_TEST_INSTALL_SCRIPT.mtsfile extension references in README (actual files are.ts)SetupHarperOptions→StartHarperOptionsand marksconfig/envas required to match the interfaceprocessandlogDirfields to theContextWithHarperinterface definition in the docsTest plan
startHarpercrash-replay.test.tsrestart pattern (killHarper→startHarper) works end-to-end🤖 Generated with Claude Code