Skip to content

Remove obsolete JavadocStyle check#1149

Closed
gianmarcoschifone wants to merge 1 commit into
HtmlUnit:masterfrom
gianmarcoschifone:remove-javadocstyle
Closed

Remove obsolete JavadocStyle check#1149
gianmarcoschifone wants to merge 1 commit into
HtmlUnit:masterfrom
gianmarcoschifone:remove-javadocstyle

Conversation

@gianmarcoschifone

Copy link
Copy Markdown

Removes the obsolete JavadocStyle check because it is being removed from Checkstyle in checkstyle/checkstyle#20582.

If this project wants to keep validating Javadoc summaries, SummaryJavadoc is the more reliable replacement because it specifically validates summary text. I did not add it here because it currently introduces 674 violations, so that migration should be handled separately.

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@romani

romani commented Jul 8, 2026

Copy link
Copy Markdown

@rbri , this is good change.
Reason of update is that long time ago htmlunit got "partnership" with checkstyle on each commit validation usage in checkstyle CI, so you get all patches of migration even before we merge breaking change.

@rbri

rbri commented Jul 9, 2026

Copy link
Copy Markdown
Member

@romani / @gianmarcoschifone

Yes remember that and had this already in mind as the reason for this heads up.
And as always good things have some coincidences - currently working on a huge cleanup of the jdoc, therfore i directly switched to the SummaryJavadoc. Yes there are >600 error now but i guess i can solve them during the next weeks.

Thanks for all the work on checkstyle!

@rbri rbri closed this Jul 9, 2026
@romani

romani commented Jul 9, 2026

Copy link
Copy Markdown

update is done at 72249ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants