implement robust error handling and fix infinite loop (Issue #51)#67
Open
imuday984 wants to merge 1 commit intoHunxByts:mainfrom
Open
implement robust error handling and fix infinite loop (Issue #51)#67imuday984 wants to merge 1 commit intoHunxByts:mainfrom
imuday984 wants to merge 1 commit intoHunxByts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several stability issues, including the infinite loop/crash reported in Issue #51, by modernizing the script's architecture and error-handling capabilities.
Key Changes:
Centralized Network Logic: Introduced a get_data() helper function. This ensures that all API calls are wrapped in try-except blocks to handle ConnectionError and Timeout gracefully without crashing the CLI.
Improved Loop Structure: Replaced recursive function calls in the main menu with a standard while True loop. This prevents potential RecursionError and improves memory efficiency.
Input Validation: Added a "catch-all" else block in the menu selection to handle invalid or empty user inputs safely.
Code Cleanliness: Utilized a decorator (@is_option) to handle UI boilerplate (clearing screen and showing banners), allowing the core logic functions to remain clean and focused.
Testing Done:
--> Tested IP Tracker with no internet connection (properly displays error instead of traceback).
-->Tested menu with invalid inputs like strings and empty spaces (re-prompts correctly).
--> Verified that the "Username Tracker" still functions with the new request helper.