Feature/comments on specific objects (some ideas) - #4959
Closed
frjo wants to merge 14 commits into
Closed
Conversation
…conditional field inclusion with `CommentForm`, small timeline formatting fixes
frjo
force-pushed
the
feature/comments-on-specific-objects-2
branch
2 times, most recently
from
August 21, 2026 07:59
3cf0143 to
a318385
Compare
frjo
changed the base branch from
main
to
feature/comments-on-specific-objects
August 21, 2026 08:00
frjo
force-pushed
the
feature/comments-on-specific-objects-2
branch
from
August 21, 2026 08:05
a318385 to
07c4dbc
Compare
Contributor
|
This is looking pretty good! @frjo when you get a chance can you add a desc/test steps? Looking through the code I think I get the main ideas though |
wes-otf
reviewed
Aug 24, 2026
| <div> | ||
| <div class="px-8 border-t h-timeline"> | ||
| {% for activity in activities %} | ||
| {# `|length` evaluates the queryset once and caches it, so the count below and #} |
Member
Author
|
@wes-otf This is mostly LLM generated, see all the test that LLM love to add. I thought it could give some neat ideas. Parts might be overly complicated. |
frjo
force-pushed
the
feature/comments-on-specific-objects
branch
from
August 25, 2026 10:38
a740ea0 to
3040f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.