UID2-1750: add explicit Lombok dependency (was relying on transitive)#614
Closed
UID2-1750: add explicit Lombok dependency (was relying on transitive)#614
Conversation
uid2-admin uses Lombok annotations (@Getter, @AllArgsConstructor, lombok.val) but was relying on Lombok being leaked transitively from uid2-shared's compile-scope dependency. Now that uid2-shared correctly scopes Lombok as provided+optional, uid2-admin must declare it explicitly. - Add Lombok 1.18.34 as provided+optional dependency - Register Lombok as annotationProcessorPath in maven-compiler-plugin Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provided+optionaldependency explicitly in uid2-admin'spom.xmlannotationProcessorPathinmaven-compiler-pluginWhy
uid2-admin uses Lombok annotations (
@Getter,@AllArgsConstructor,lombok.val) but was silently relying on Lombok leaking transitively from uid2-shared's incorrectcompile-scope declaration. The companion PR [IABTechLab/uid2-shared#...] fixes uid2-shared to declare Lombok asprovided+optional, which stops the transitive leak. uid2-admin must therefore declare Lombok explicitly. See UID2-1750.Test plan
mvn compilepasses (151 source files, 0 errors)mvn testpasses (698 tests, 0 failures, 1 skipped)mvn dependency:tree | grep lombokshowsprovidedscope (notcompile)🤖 Generated with Claude Code