UID2-7075 Fix UID2Prebid compile error with PrebidMobile 3.3.1+#91
Closed
sunnywu wants to merge 1 commit into
Closed
UID2-7075 Fix UID2Prebid compile error with PrebidMobile 3.3.1+#91sunnywu wants to merge 1 commit into
sunnywu wants to merge 1 commit into
Conversation
PrebidMobile 3.3.1 (prebid/prebid-mobile-ios#1257) renamed the `UserUniqueID` initializer parameter from `id:` to `uniqueId:` to fix an Objective-C interoperability conflict, and renamed the Swift property accordingly. Update our call sites in UID2Prebid and the tests to match, and raise the PrebidMobile minimum (SPM and CocoaPods) to 3.3.1 so consumers can't resolve a version where the parameter name doesn't match the call site. Fixes #87 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UID2Prebid(andUID2PrebidTests) to PrebidMobile's renamedUserUniqueID.uniqueIdparameter/property — see Fix Objective-C interoperability conflict by renaming UserUniqueID.id to uniqueId prebid/prebid-mobile-ios#1257 (shipped in PrebidMobile 3.3.1).Package.swiftto3.3.1and inUID2Prebid.podspec.jsonto>= 3.3.1, < 4.0so consumers can't resolve a version where the parameter name doesn't match the call site.Package.resolvedincludes a forced transitive bump ofswift-package-manager-google-mobile-adsfrom12.7.0to13.3.0, because PrebidMobile 3.3.1 requires.upToNextMajor(from: "13.0.0").Test plan
test-pull-request.yml(UID2 + UID2Prebid tests)lint-prebid-podspec.ymlswift build/ Xcode build ofUID2Prebidagainst PrebidMobile 3.3.1