Feature Request: API to support Download Terms of Use and Guestbook

[stevenwinship]

What this PR does / why we need it:

Which issue(s) this PR closes: #12001

• Closes Feature Request: API to support Download Terms of Use #12001

Special notes for your reviewer:
Git got a bit confused when I added Access.java: POST @path("dataset/{id}") above GET @path("dataset/{id}/versions/{versionId}") It shows lots of diffs that aren't really there :(

Suggestions on how to test this: See AccessIT for testing with -Ddataverse.files.guestbook-at-request=true

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

https://dataverse-guide--12110.org.readthedocs.build/en/12110/api/native-api.html#guestbooks

[coveralls]

coverage: 24.847% (+0.1%) from 24.718%
when pulling 63db903 on 12001-api-support-termofuse-guestbook
into 89cf927 on develop.

[stevenwinship]

@ChengShi-1 @sekmiller @pdurbin
I fixed the issue with the persistentId. I guess it needs to be reviewed again since it wasn't just a test fix

[pdurbin]

@ChengShi-1 @sekmiller @pdurbin I fixed the issue with the persistentId. I guess it needs to be reviewed again since it wasn't just a test fix

It looks ok to me. df.getOwner().getId() should never be null. (Famous last words.) 😄

[pdurbin]

Found some typos.

[stevenwinship]

@pdurbin lucky df.getOwner().getId() was checked before this method was called so, fingers crossed, we should be ok :)

[github-actions]

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12001-api-support-termofuse-guestbook

ghcr.io/gdcc/configbaker:12001-api-support-termofuse-guestbook

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

[ekraffmiller]

Hi @stevenwinship I have one more small (I hope) change request: for the Create Guestbook API, can you return HTTP response type 201, instead of 200, and return the id of the created guestbook as a field rather than in a message? It will help the client to have the id of the newly created object. (You don't have to include "name", that's just a suggestion).

So for example:
{
  "status": "OK",
  "data": { "id" : 45,
  "name": "guestbook name" }
}

[sekmiller]

I wasn't able to find anything else that needs to be changed, so I think once Ellen's request gets in we can merge. Thanks for your patience.