Open
Conversation
RobLoach
requested changes
Apr 12, 2026
Contributor
RobLoach
left a comment
RobLoach
left a comment
There was a problem hiding this comment.
I believe we should only act on ctrl q within the demo apps, not the renderers themselves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #935
Sorry for the delay.
Also fixes some C++ issues in Overview that showed up when compiling the SFML demos.
I personally ran the all SDL (except the old broken sdl3), sfml, glfw backends, plus the x11, x11_opengl2, x11_opengl3, and allegro5 backends. Pretty sure I can vouch for those.
I have not tested the d3d or gdi backends that I did change.
There are others that I didn't touch and we have several that should probably just be removed if we aren't going to be able to keep them up to date. Or at least mark them officially.
During my testing I also noticed that in most backends I could not trigger the double click indicator in the new Input section of Overview. Something to look into for later.
@RobLoach @sleeptightAnsiC
Edit: typos, clarification etc.