-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add ccl registry, fix profiler #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chamberlain0w0
wants to merge
6
commits into
master
Choose a base branch
from
feat/ccl_registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
20ea5b2
draft: remove ProgressGroup and Work derivitives for NCCL
Chamberlain0w0 98a8dfe
fix: fix nccl error in process_group and seg fault in profiler
Chamberlain0w0 4fa71bc
feat: integrate runtime_common, and modify ProcessGroup related apis
Chamberlain0w0 ff5d317
fix: add EventFlag enum, fix mutex usage in ProcessGroupFactory::Inst…
Chamberlain0w0 c289934
fix: resolve requested changes, remove unnecessary api, remove nccl m…
Chamberlain0w0 39bbf48
fix: save device/ccl impl in ProcessGroup
Chamberlain0w0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| #pragma once | ||
|
|
||
| #include <cstddef> | ||
| #include <cstdint> | ||
| #include <memory> | ||
| #include <string> | ||
| #include <unordered_map> | ||
|
|
||
| #include "infini_train/include/core/ccl/ccl_common.h" | ||
| #include "infini_train/include/datatype.h" | ||
| #include "infini_train/include/device.h" | ||
| #include "infini_train/include/nn/parallel/reduce_op_type.h" | ||
|
|
||
| namespace infini_train::core { | ||
|
|
||
| class Stream; | ||
|
|
||
| class CclImpl { | ||
| public: | ||
| CclImpl() {} | ||
| virtual ~CclImpl() = default; | ||
|
|
||
| virtual Device::DeviceType Type() const = 0; | ||
|
|
||
| virtual void GroupStart() const; | ||
|
|
||
| virtual void GroupEnd() const; | ||
|
|
||
| virtual void GetAsyncError(const CclComm *comm, CclStatus *async_error) const; | ||
|
|
||
| virtual void GetUniqueId(CclUniqueId **unique_id) const; | ||
|
|
||
| virtual void CommInitAll(CclComm **comms, int ndev, const int *devlist) const; | ||
|
|
||
| virtual void CommInitRank(CclComm **comm, int nranks, const CclUniqueId &unique_id, int rank) const; | ||
|
|
||
| virtual void CommDestroy(CclComm *comm) const; | ||
|
|
||
| virtual void AllReduce(const void *sendbuff, void *recvbuff, size_t count, DataType dtype, | ||
| nn::parallel::function::ReduceOpType reduce_op, const CclComm *comm, Stream *stream) const; | ||
|
|
||
| virtual void Broadcast(const void *sendbuff, void *recvbuff, size_t count, DataType dtype, int root, | ||
| const CclComm *comm, Stream *stream) const; | ||
|
|
||
| virtual void Reduce(const void *sendbuff, void *recvbuff, size_t count, DataType dtype, | ||
| nn::parallel::function::ReduceOpType reduce_op, int root, const CclComm *comm, | ||
| Stream *stream) const; | ||
|
|
||
| virtual void AllGather(const void *sendbuff, void *recvbuff, size_t count, DataType dtype, const CclComm *comm, | ||
| Stream *stream) const; | ||
|
|
||
| virtual void ReduceScatter(const void *sendbuff, void *recvbuff, size_t recv_count, DataType dtype, | ||
| nn::parallel::function::ReduceOpType reduce_op, const CclComm *comm, | ||
| Stream *stream) const; | ||
|
|
||
| virtual void Send(const void *buff, size_t count, DataType dtype, int peer, const CclComm *comm, | ||
| Stream *stream) const; | ||
|
|
||
| virtual void Recv(void *buff, size_t count, DataType dtype, int peer, const CclComm *comm, Stream *stream) const; | ||
| }; | ||
|
|
||
| class CclGroupGuard { | ||
| public: | ||
| explicit CclGroupGuard(Device::DeviceType type); | ||
| ~CclGroupGuard(); | ||
|
|
||
| CclGroupGuard(const CclGroupGuard &) = delete; | ||
| CclGroupGuard &operator=(const CclGroupGuard &) = delete; | ||
| CclGroupGuard(CclGroupGuard &&) = delete; | ||
| CclGroupGuard &operator=(CclGroupGuard &&) = delete; | ||
|
|
||
| private: | ||
| CclImpl *impl_ = nullptr; | ||
| }; | ||
|
|
||
| class CclImplRegistry { | ||
| public: | ||
| static CclImplRegistry &Instance(); | ||
|
|
||
| void Register(Device::DeviceType type, std::unique_ptr<CclImpl> impl); | ||
|
|
||
| CclImpl *Get(Device::DeviceType type) const; | ||
|
|
||
| private: | ||
| CclImplRegistry() = default; | ||
| CclImplRegistry(const CclImplRegistry &) = delete; | ||
| CclImplRegistry &operator=(const CclImplRegistry &) = delete; | ||
|
|
||
| std::unordered_map<Device::DeviceType, std::unique_ptr<CclImpl>> impls_; | ||
| }; | ||
|
|
||
| CclImpl *GetCclImpl(Device::DeviceType type); | ||
|
|
||
| } // namespace infini_train::core | ||
|
|
||
| #define INFINI_TRAIN_REGISTER_CCL_IMPL(device_type, class_impl) \ | ||
| static const bool __infini_train_ccl_registered##__COUNTER__ = []() { \ | ||
| infini_train::core::CclImplRegistry::Instance().Register(device_type, std::make_unique<class_impl>()); \ | ||
| return true; \ | ||
| }(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| #pragma once | ||
|
|
||
| #include <cstddef> | ||
| #include <cstdint> | ||
|
|
||
| #include "glog/logging.h" | ||
|
|
||
| namespace infini_train::core { | ||
|
|
||
| #define INFINI_TRAIN_CCL_STATUS_LIST(X) \ | ||
| X(kSuccess, 0) \ | ||
| X(kInProgress, 1) \ | ||
| X(kTimeout, 2) \ | ||
| X(kError, -1) \ | ||
| X(kInvalidArgument, -2) \ | ||
| X(kUnavailable, -3) \ | ||
| X(kNotSupported, -4) \ | ||
| X(kInternal, -5) \ | ||
| X(kUnknown, -127) | ||
|
|
||
| enum class CclStatus : int32_t { | ||
| #define INFINI_TRAIN_CCL_STATUS_ENUM_ITEM(name, value) name = value, | ||
| INFINI_TRAIN_CCL_STATUS_LIST(INFINI_TRAIN_CCL_STATUS_ENUM_ITEM) | ||
| #undef INFINI_TRAIN_CCL_STATUS_ENUM_ITEM | ||
| }; | ||
|
|
||
| inline const char *CclStatusToString(CclStatus status) { | ||
| switch (status) { | ||
| #define INFINI_TRAIN_CCL_STATUS_CASE(name, value) \ | ||
| case CclStatus::name: \ | ||
| return #name; | ||
| INFINI_TRAIN_CCL_STATUS_LIST(INFINI_TRAIN_CCL_STATUS_CASE) | ||
| #undef INFINI_TRAIN_CCL_STATUS_CASE | ||
| default: | ||
| LOG(FATAL) << "Unsupported RuntimeStatus type: " << static_cast<int>(status); | ||
| return ""; | ||
| } | ||
| } | ||
|
|
||
| #undef INFINI_TRAIN_CCL_STATUS_LIST | ||
|
|
||
| class CclComm { | ||
| public: | ||
| CclComm() = default; | ||
| virtual ~CclComm() = default; | ||
| }; | ||
|
|
||
| class CclUniqueId { | ||
| public: | ||
| CclUniqueId() = default; | ||
| virtual ~CclUniqueId() = default; | ||
|
|
||
| virtual size_t Size() const = 0; | ||
| virtual const void *Data() const = 0; | ||
| virtual void Load(const void *src, size_t size) = 0; | ||
| }; | ||
|
|
||
| } // namespace infini_train::core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| #pragma once | ||
|
|
||
| #include <string> | ||
|
|
||
| #include "infini_train/include/core/ccl/ccl_common.h" | ||
|
|
||
| namespace infini_train::core { | ||
|
|
||
| void WriteUniqueIdFile(const CclUniqueId &unique_id, const std::string &pg_name); | ||
|
|
||
| void ReadUniqueIdFile(CclUniqueId *unique_id, const std::string &pg_name); | ||
|
|
||
| void CleanupUniqueIdFile(const std::string &pg_name); | ||
|
|
||
| } // namespace infini_train::core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.