Add support for raw_kernel_arg extension#2038
Add support for raw_kernel_arg extension#2038ndgrigorian merged 3 commits intoIntelPython:masterfrom
Conversation
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
|
@sommerlukas |
1ea6b9c to
296e236
Compare
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
libsyclinterface/include/syclinterface/dpctl_sycl_extension_interface.h
Outdated
Show resolved
Hide resolved
Switch approach to not introduce an intermediate struct, but have the opaque pointer directly point to std::vector instead.
|
Thanks for the feedback @ndgrigorian @AlexanderKalistratov! After taking a look at how the opaque pointers for other |
ba642e9 to
a0b4c75
Compare
|
@ndgrigorian @AlexanderKalistratov Friendly ping for reviews. CI is looking quite good now, I can unfortunately not see the logs for the single failing Jenkins job. |
AlexanderKalistratov
left a comment
There was a problem hiding this comment.
@sommerlukas PR looks great for me, thank you!
I'm not code owner, so we need to wait @ndgrigorian review as well
Sorry, forgot to put my final review on this. Jenkins job is unrelated. I'll give it a last look over but I think it's ready to go in. |
Add support for the DPC++ SYCL extension
raw_kernel_argthat allows to pass a binary blob as kernel arguments.This is for example useful if the kernel uses a
structas kernel parameter, but is loaded from SPIR-V and the argument type is unknown forset_arg.The implementation follows #1984.