Change "max dimensions" to None in array API capabilities#2071
Change "max dimensions" to None in array API capabilities#2071ndgrigorian merged 1 commit intomasterfrom
"max dimensions" to None in array API capabilities#2071Conversation
`usm_ndarray` can support potentially arbitrary dimensions
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_179 ran successfully. |
There was a problem hiding this comment.
LGTM! Thank you @ndgrigorian
Do we need to note the change in CHANGELOG.md? Or it will be done before the release directly?
It will be done before the release. Adding to changelog as a task was added to simplify the process at release, but it was found that it didn't really help avoid a number of ugly merge conflicts, etc. Really the chore should be removed and we should switch to towncrier. |
[dpctl-2071](IntelPython/dpctl#2071) is going to change `"max dimensions"` to `None` in array API capabilities. This PR updates a test to align with that change.
[dpctl-2071](IntelPython/dpctl#2071) is going to change `"max dimensions"` to `None` in array API capabilities. This PR updates a test to align with that change. 2b30bab
tensor.usm_ndarraycan support potentially arbitrary dimensionsChanges will need to be made where NumPy arrays are created from
usm_ndarray(printing, dlpack withkDLCPU,asnumpy/from_numpy)