Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts AR-speculative decoding to correctly track/trim routed MoE expert history and to fix stop-word masking behavior during stopping-criteria evaluation.
Changes:
- Add
SchedulerSequenceARSpec.routed_expertsoverride to base routed-experts retrieval onnum_valid_ids. - Resize routed-expert history when truncating a sequence via
set_stop_pos. - Fix stop-criteria masking by using logical OR with
stop_maskinstead of XOR.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lmdeploy/pytorch/strategies/ar_spec/sequence.py | Adds routed-experts accessor for AR-spec sequences and attempts to keep routed-expert history aligned when truncating tokens. |
| lmdeploy/pytorch/strategies/ar_spec/model_agent.py | Fixes stop-word masking logic in ARSpec stopping criteria. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d92cbe0 to
6f06f1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist