fix: prevent prefill starvation under high decode load#4532
Open
grimoire wants to merge 4 commits intoInternLM:mainfrom
Open
fix: prevent prefill starvation under high decode load#4532grimoire wants to merge 4 commits intoInternLM:mainfrom
grimoire wants to merge 4 commits intoInternLM:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PyTorch engine input scheduling policy to prevent prefill starvation when decode load is high, by introducing a “max consecutive decode rounds” guard that forces a prefill attempt when requests are waiting.
Changes:
- Add
InputsMakerConfig.max_prefill_gap(sourced fromengine.engine_config.prefill_interval) to control how many consecutive decode rounds are allowed before forcing prefill. - Track consecutive decode rounds via
InputsMakerAsync._decode_count, forcing prefill once the threshold is reached while requests are waiting. - Reset the counter only when a prefill actually produces inputs (not merely when prefill is attempted).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents waiting requests from being starved by continuous decode selection under high decode load in the PyTorch engine’s input-making/scheduling logic.
Changes:
- Add
prefill_intervaltoInputsMakerConfig(default 16) and plumb it fromengine.engine_config. - Track consecutive decode decisions via
_decode_countand force a prefill once the interval is reached while requests are waiting. - Reset
_decode_countonly when a non-decodingModelInputsis actually produced.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary