Merged
Conversation
49a5b3e to
02fcb8c
Compare
e02c28e to
a9f1a86
Compare
20c16c7 to
9366523
Compare
… Cardano.Api.Serialise.Cbor
9366523 to
9539675
Compare
Jimbo4350
requested changes
Jan 20, 2026
Contributor
Jimbo4350
left a comment
There was a problem hiding this comment.
Strongly opposed to the default language extensions. Other than that LGTM.
cardano-rpc/cardano-rpc.cabal
Outdated
| common project-config | ||
| default-language: Haskell2010 | ||
| default-extensions: | ||
| BangPatterns |
Contributor
There was a problem hiding this comment.
I prefer per module explicit language extensions at the top of the module.
| deserialiseFromRawBytes AsWord64 = deserialiseWord | ||
|
|
||
| -- | Deserialise any length number. | ||
| deserialiseWord |
Contributor
There was a problem hiding this comment.
Is there no haskell library that does this?
Contributor
Author
There was a problem hiding this comment.
I was not able to find one. Existing ones like cereal or binary assume the constant size for a type i.e. Word32 is always 32 bytes. This encoding uses variable length. So either I'd have to pad it with leading zeroes or just use simple BS.foldl' (\acc b -> acc shiftL 8 .|. fromIntegral b) 0
9539675 to
e998234
Compare
Jimbo4350
approved these changes
Jan 21, 2026
e998234 to
f9154a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
The changes are integrated in IntersectMBO/cardano-node#6273
Checklist