cardano-testnet enableP2P in config file#6439
Open
CarlosLopezDeLara wants to merge 1 commit intomasterfrom
Open
cardano-testnet enableP2P in config file#6439CarlosLopezDeLara wants to merge 1 commit intomasterfrom
CarlosLopezDeLara wants to merge 1 commit intomasterfrom
Conversation
CarlosLopezDeLara
force-pushed
the
clr/enablep2p
branch
5 times, most recently
from
c2b74cc to
152730f
Compare
Enhances the `cardano-testnet` user experience by refining startup output. Improve messages when running the testnet The HTTP call fetching mainnet protocol parameters from https://github.com/input-output-hk/cardano-parameters/blob/main/mainnet/parameters.json had no retry logic, so a transient network or TLS error would kill the testnet setup with an opaque exception. Retry up to 3 times with a 2-second delay, logging each attempt to stderr, and wrap the final failure in a descriptive error. Update node_default_config.json
CarlosLopezDeLara
force-pushed
the
clr/enablep2p
branch
from
152730f to
b9e77bc
Compare
carbolymer
reviewed
Feb 13, 2026
| -- Turn logging on or off | ||
| , ("EnableLogging", Aeson.Bool True) | ||
|
|
||
| -- Configuration for the node's P2P network topology |
Contributor
There was a problem hiding this comment.
This parameter is not in use for node versions >= 10.6. Can you add a comment about that?
c.f. 833a5f7#diff-d4a6c1d885d0454ec160da57fbe77f888d95b0c069a3e7f91449f49e2b84a237L196
carbolymer
reviewed
Feb 13, 2026
| makeSocketDir (TmpAbsolutePath fp) = | ||
| let relPath = makeRelative (takeDirectory fp) fp | ||
| in if relPath == "." | ||
| then "socket" |
Contributor
There was a problem hiding this comment.
Is anything wrong with ./socket here?
carbolymer
reviewed
Feb 13, 2026
| logInfo "Node sockets:" | ||
| forM_ nodes $ \node -> | ||
| logInfo $ " " <> display (Text.pack (nodeName node)) <> " " <> display (Text.pack (H.sprocketSystemName (nodeSprocket node))) | ||
| logInfo "" |
Contributor
There was a problem hiding this comment.
Good idea with dumping cli connection details.
carbolymer
approved these changes
Feb 13, 2026
Contributor
carbolymer
left a comment
carbolymer
left a comment
There was a problem hiding this comment.
LGTM, just add a comment about EnableP2P.
Jimbo4350
requested changes
Feb 13, 2026
| , ("EnableLogging", Aeson.Bool True) | ||
|
|
||
| -- Configuration for the node's P2P network topology | ||
| , ("EnableP2P", Aeson.Bool True) |
Contributor
There was a problem hiding this comment.
I think we need more nuance here. Technically this configuration field has been deprecated so it's not relevant to node master. If we are going to support multiple versions, hard coding a deprecated field is not the way to start that process.
| makeSocketDir (TmpAbsolutePath fp) = | ||
| let relPath = makeRelative (takeDirectory fp) fp | ||
| in if relPath == "." | ||
| then "socket" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
EnableP2P: truenetworking in the default testnet node configuration.--params-mainnetHTTP request: retries up to 3 times with a 2-second delay, logging each failure to stderr, and wraps the final failure in a descriptiveMainnetParamsFetchErrorinstead of an opaque exception
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.